New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check into UrlMixin and get_url #157

Closed
atodorov opened this Issue Dec 22, 2017 · 0 comments

Comments

Projects
None yet
1 participant
@atodorov
Member

atodorov commented Dec 22, 2017

There's a UrlMixin base class which looks like it can be removed. It defines couple of methods but then they appear to be overriden in inherited classes.

Need to examine how we use these methods and if we can remove the UrlMixin class.

atodorov added a commit that referenced this issue Mar 21, 2018

Rewrite UrlMixin. Fixes #157
UrlMixin is too old. It can be rewrite in Django builtin functionalities
nowadays. In templates, a get_absolute_url is enough to render the path
part of a model object, and some of URLs can be constructed by using
Site app in the meanwhile.

Signed-off-by: Chenxiong Qi <qcxhome@gmail.com>

@atodorov atodorov closed this in 9c9e614 Mar 21, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment