New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename / disable Environment Properties fails #167

Closed
xbln opened this Issue Jan 2, 2018 · 1 comment

Comments

Projects
None yet
2 participants
@xbln

xbln commented Jan 2, 2018

Description of problem

Click on "rename" on last item in list loads "New property name"-box with "null", changes will not be accepted ("ID is required"). Disabling fails.
Workaround: Page refresh

Component (web, API, etc)

web

Version or commit hash (if applicable)

3.49ee

How often reproducible

allways

image

@xbln xbln changed the title from Rename Environment Properties fails to Rename / disable Environment Properties fails Jan 2, 2018

@atodorov

This comment has been minimized.

Member

atodorov commented Jan 2, 2018

Do you have any values assigned to this property before Trying to rename to 'null' ?

I was able to successfully rename another property on the demo site. Then I added a new property with name 'Notebook Display 1366744', without any values and then tried to rename it. Only then I got the error which makes me think the '' in the name could be to blame.

If you can get an exact reproducer that would be very helpful

atodorov added a commit that referenced this issue Jan 19, 2018

Correctly find property ID when renaming. Fixes #167
the problem was that for newly added property the 'Rename' action
only searched its immediate parent while the object ID was stored
one level up. This commit updates how we search for the parent.

Also update the template for newly added property to match the
existing HTML for other properties!

@atodorov atodorov closed this in 06913be Jan 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment