New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[refactor] add/remove bug to use common implementation #18

Open
atodorov opened this Issue May 26, 2017 · 0 comments

Comments

Projects
None yet
1 participant
@atodorov
Copy link
Member

atodorov commented May 26, 2017

While working on upstream #79 I have discovered that for adding and removing bugs we use separate code paths which are very similar. This applies both to the Python code and to the JavaScript code. These can be refactored to use a single implementation.

  • Test Case Run add/remove bug uses testruns.views.bug() and its internal class CaseRunBugActions and from tesrun_actions.js -> addCaseRunBug(), removeCaseRunBug(), updateBugsActionAdd() and updateBugsActionRemvoe()
  • Test Case, tab Bugs uses testcases.views.bug() and its internal class CaseBugActions and from testcase_actions.js -> addCaseBug() and removeCaseBug().

@atodorov atodorov added the refactoring label Nov 7, 2017

atodorov added a commit that referenced this issue Dec 18, 2018

atodorov added a commit that referenced this issue Dec 19, 2018

atodorov added a commit that referenced this issue Dec 22, 2018

Refactor removeCaseRunBug() to JSON-RPC, Refs #18
the UI updates are a bit tricky b/c we still show bugs that have
been reported in other TestRuns or generally attached to the
TestCase. The idea is that these can be known issues and should be
easy to find when testing (i.e. we're seeing this behavior for the
first time but somebody else had reported it already).

atodorov added a commit that referenced this issue Dec 22, 2018

Refactor removeCaseRunBug() to JSON-RPC, Refs #18
the UI updates are a bit tricky b/c we still show bugs that have
been reported in other TestRuns or generally attached to the
TestCase. The idea is that these can be known issues and should be
easy to find when testing (i.e. we're seeing this behavior for the
first time but somebody else had reported it already).

@atodorov atodorov changed the title [refactor] add/remove bug to use common implementation #184 [refactor] add/remove bug to use common implementation Jan 13, 2019

atodorov added a commit that referenced this issue Jan 13, 2019

Implement Bugs card for Test Case page. Refs #18
Note: this is missing the add/remove functionality for now.
Bug.remove is very powerful and can remove bugs that are
attached to a TC but not coming from executions and also
bugs that are coming from executions.

Adding bugs is the reverse operation and I'm not quite sure how
that functionality is used outside test runs!

atodorov added a commit that referenced this issue Jan 13, 2019

Implement Bugs card for Test Case page. Refs #18
Note: this is missing the add/remove functionality for now.
Bug.remove is very powerful and can remove bugs that are
attached to a TC but not coming from executions and also
bugs that are coming from executions.

Adding bugs is the reverse operation and I'm not quite sure how
that functionality is used outside test runs!

atodorov added a commit that referenced this issue Jan 13, 2019

Implement Bugs card for Test Case page. Refs #18
Note: this is missing the add/remove functionality for now.
Bug.remove is very powerful and can remove bugs that are
attached to a TC but not coming from executions and also
bugs that are coming from executions.

Adding bugs is the reverse operation and I'm not quite sure how
that functionality is used outside test runs!

atodorov added a commit that referenced this issue Jan 15, 2019

Implement Bugs card for Test Case page. Refs #18
Note: this is missing the add/remove functionality for now.
Bug.remove is very powerful and can remove bugs that are
attached to a TC but not coming from executions and also
bugs that are coming from executions.

Adding bugs is the reverse operation and I'm not quite sure how
that functionality is used outside test runs!

atodorov added a commit that referenced this issue Jan 15, 2019

Remove old templates and unused code around them
- remove all legacy templates around the TestCase view page
- remove now unused JavaScript, lots of functions around
  tabs and expanding content
- remove backend views which were only used via AJAX calls
  from the removed templates, Refs #18
- remove/update tests, in particular the new view renders
  only TestPlans which have a Test Run executed, including the
  current TestCase. Other TestPlans which contain the current
  TestCase (but may not yet have test runs) are loaded via RPC
  for which we can't test right now.

atodorov added a commit that referenced this issue Jan 16, 2019

Implement Bugs card for Test Case page. Refs #18
Note: this is missing the add/remove functionality for now.
Bug.remove is very powerful and can remove bugs that are
attached to a TC but not coming from executions and also
bugs that are coming from executions.

Adding bugs is the reverse operation and I'm not quite sure how
that functionality is used outside test runs!

atodorov added a commit that referenced this issue Jan 16, 2019

Remove old templates and unused code around them
- remove all legacy templates around the TestCase view page
- remove now unused JavaScript, lots of functions around
  tabs and expanding content
- remove backend views which were only used via AJAX calls
  from the removed templates, Refs #18
- remove/update tests, in particular the new view renders
  only TestPlans which have a Test Run executed, including the
  current TestCase. Other TestPlans which contain the current
  TestCase (but may not yet have test runs) are loaded via RPC
  for which we can't test right now.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment