New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[refactoring] - Seemingly duplicate ComponentActions class #193 #20

Closed
atodorov opened this Issue May 26, 2017 · 3 comments

Comments

Projects
None yet
1 participant
@atodorov
Member

atodorov commented May 26, 2017

testcases/actions.py:class ComponentActions and inner testplans/views.py: class ComponentActions appear to be very similar. Need to investigate and refactor, leaving only one of them with full test coverage.

Note: this is similar to #184

@atodorov atodorov added the refactoring label Nov 7, 2017

@atodorov

This comment has been minimized.

Member

atodorov commented Dec 8, 2017

@atodorov

This comment has been minimized.

Member

atodorov commented Mar 5, 2018

Note: the above PR is probably not very relevant ATM and still doesn't quite address the code duplication issue.

@atodorov

This comment has been minimized.

Member

atodorov commented Oct 24, 2018

NOTE2: It is probably better to upgrade these methods to use the existing JSON-RPC instead.

atodorov added a commit that referenced this issue Nov 13, 2018

Remove ComponentActions() class. Fixes #20
with the latest commits all component actions in the UI have been
converted to reuse the existing JSON-RPC methods and we no-longer
need this duplicated functionality.

@atodorov atodorov closed this in f3db4be Nov 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment