Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert jQ to $ #212

Closed
atodorov opened this issue Feb 12, 2018 · 0 comments
Closed

Convert jQ to $ #212

atodorov opened this issue Feb 12, 2018 · 0 comments

Comments

@atodorov
Copy link
Member

@atodorov atodorov commented Feb 12, 2018

Inside Kiwi's templates jQuery is registered with the jQ variable. At the same time there are other .js files (e.g. Grappelli and Django Admin) which also require jQuery and register it as $.

First step is to convert everything to $ and figure out how to get rid of the vendored dependencies of jQuery, ideally using the jQuery version coming from Django Admin (or Grappelli since it is used for the admin forms).

@atodorov atodorov added the UI/UX label Aug 2, 2018
@atodorov atodorov added this to the patternfly-migration milestone Jan 17, 2020
atodorov added a commit that referenced this issue Nov 8, 2020
- after v8.8 these are now unused
- Closes #212 b/c there are no more legacy `jQ` references
- Closes #1382 b/c there are no more legacy `jQ.bind` references
- Closes #431 b/c there are no more references to `fireEvent()`
atodorov added a commit that referenced this issue Nov 9, 2020
- after v8.8 these are now unused
- Closes #212 b/c there are no more legacy `jQ` references
- Closes #1382 b/c there are no more legacy `jQ.bind` references
- Closes #431 b/c there are no more references to `fireEvent()`
atodorov added a commit that referenced this issue Nov 20, 2020
- after v8.8 these are now unused
- Closes #212 b/c there are no more legacy `jQ` references
- Closes #1382 b/c there are no more legacy `jQ.bind` references
- Closes #431 b/c there are no more references to `fireEvent()`
atodorov added a commit that referenced this issue Dec 1, 2020
- after v8.8 these are now unused
- Closes #212 b/c there are no more legacy `jQ` references
- Closes #1382 b/c there are no more legacy `jQ.bind` references
- Closes #431 b/c there are no more references to `fireEvent()`
@atodorov atodorov closed this in 5394a9d Dec 1, 2020
asankov added a commit to asankov/Kiwi that referenced this issue Dec 2, 2020
- after v8.8 these are now unused
- Closes kiwitcms#212 b/c there are no more legacy `jQ` references
- Closes kiwitcms#1382 b/c there are no more legacy `jQ.bind` references
- Closes kiwitcms#431 b/c there are no more references to `fireEvent()`
asankov added a commit to asankov/Kiwi that referenced this issue Dec 2, 2020
- after v8.8 these are now unused
- Closes kiwitcms#212 b/c there are no more legacy `jQ` references
- Closes kiwitcms#1382 b/c there are no more legacy `jQ.bind` references
- Closes kiwitcms#431 b/c there are no more references to `fireEvent()`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants