New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Email notifications (at least for test runs) are broken #225

Closed
okainov opened this Issue Feb 20, 2018 · 1 comment

Comments

Projects
None yet
1 participant
@okainov
Contributor

okainov commented Feb 20, 2018

WARNING: do not publically report security issues in the bug tracker!
Ping us via email to coordinate the fix and disclosure of the problem!

Description of problem

Looks like recent changes in email notification broke template rendering

Component (web, API, etc)

core

Version or commit hash (if applicable)

latest

How often reproducible

often

Steps to Reproduce

  1. Enable emails
  2. Perform any action leading to email notification with test run

Actual results

Empty template email will be sent

Test run  has been created or updated for you.

### Links ###
Test run: 
Test plan: 

### Basic run information ###
Summary: 

Managed: .
Default tester: .

Product: 
Product version: 
Build: 

Estimated time: 

Notes:


Expected results

Email template should be filled with the data

Additional info

@okainov

This comment has been minimized.

Contributor

okainov commented Feb 20, 2018

Looks like the root cause is blocktrans section in the template. See https://docs.djangoproject.com/en/2.0/topics/i18n/translation/#std:templatetag-blocktrans - as I understood you shouldn't put all the text into translation block, you should put separated sentences\context-free sentences to those blocks. In addition, you should use "with" construction to bind string with variables value

atodorov added a commit that referenced this issue Feb 20, 2018

Properly pass variables to blocktrans tag. Fixes #225
the problem seems to be that in blocktrans you can't use
dotted variables (i.e. objects) so everything needs to be broken
down into scalars.

@atodorov atodorov closed this in 6ee132f Feb 21, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment