New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove is_int() #269

Closed
atodorov opened this Issue Mar 25, 2018 · 1 comment

Comments

Projects
None yet
2 participants
@atodorov
Member

atodorov commented Mar 25, 2018

The is_int utils function is used in only one place and I think it can be removed after the code which uses it is refactored a bit to make it more clear what is happening.

@atodorov

This comment has been minimized.

Member

atodorov commented Jun 25, 2018

Note: is_int() is used in plan_by_id_or_name() which in turn is used by TestRun.list() which is used in 2 places:

  1. when listing test runs on the dashboard page

  2. when searching test runs and scrolling through the JS pagination buttons in the results. This calls the /runs/ajax/ URL which basically duplicates the search but returns a very ugly JSON instead of HTML.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment