New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor tcms.testcases.views.plan_from_request_or_none method #303

Open
asankov opened this Issue Apr 7, 2018 · 0 comments

Comments

Projects
None yet
1 participant
@asankov
Member

asankov commented Apr 7, 2018

Currently, this method accepts both GET and POST request. We need to examine carefully whether this is the desired functionality.

Also, the current implementation returns either TestPlan object, an id or None. In my opinion, returning just the id is useless, because if you need just the id you can get it directly from the request, without calling this method. Moreover, this functionality (that returns just the id) is used at only one place. This means we can easily remove it from the method.

asankov added a commit to asankov/Kiwi that referenced this issue Nov 18, 2018

asankov added a commit to asankov/Kiwi that referenced this issue Nov 18, 2018

asankov added a commit to asankov/Kiwi that referenced this issue Nov 18, 2018

asankov added a commit that referenced this issue Nov 18, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment