Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Don't spam emails during test case run status updates #367
added a commit
Jul 20, 2018
@atodorov why? This feature was pretty useful and I would even say that is should be enabled by default. Because you will always forget to click "set as finished", and automatic update was nice.
My issue here was only in calling "save" all the time, not with the feature itself.
@okainov - the answer of "why remove it" is that this feature as it was implemented was more trouble than it's worth it. I personally think this should be done automatically without asking when the last test case has been executed (this is missing, feel free to request it and let's count the +1s).
OTOH I like to keep runs unfinished so they are available on my dashboard until I don't need them anymore.
Edit: signals in Django (which are triggered post_save and send the emails) have no idea about what triggered them. So we'd have to implement some logic that teaches the code to ignore signals if the status was updated automatically. Not a good proposal either.