New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFE: consider removing get_full_url() #380

Closed
atodorov opened this Issue Jun 22, 2018 · 3 comments

Comments

Projects
None yet
1 participant
@atodorov
Member

atodorov commented Jun 22, 2018

This method relies on the actual ip/fqdn being properly configured to produce a full URL to the given object. This often leads to issues.

Items to consider:

  1. Remove the hostname part of the URL and use relative URLs starting at /.

ATM I don't know why initially we've considered linking via the full URL.

  1. Use a different method of linking between objects: this will likely require lots of updates to templates.
@atodorov

This comment has been minimized.

Show comment
Hide comment
@atodorov

atodorov Jun 22, 2018

Member

Note: for integration with external services like email/bugtracker reports we still need the full URLs.

Member

atodorov commented Jun 22, 2018

Note: for integration with external services like email/bugtracker reports we still need the full URLs.

@atodorov

This comment has been minimized.

Show comment
Hide comment
@atodorov

atodorov Jul 29, 2018

Member

Related to #450 - if we didn't use get_full_url everywhere this problem would have been less visible.

Member

atodorov commented Jul 29, 2018

Related to #450 - if we didn't use get_full_url everywhere this problem would have been less visible.

@atodorov

This comment has been minimized.

Show comment
Hide comment
@atodorov

atodorov Aug 17, 2018

Member

#478 is also manifestation of this issue

Member

atodorov commented Aug 17, 2018

#478 is also manifestation of this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment