Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove JavaScript fireEvent() #431

Closed
atodorov opened this issue Jul 15, 2018 · 0 comments
Closed

Remove JavaScript fireEvent() #431

atodorov opened this issue Jul 15, 2018 · 0 comments

Comments

@atodorov
Copy link
Member

@atodorov atodorov commented Jul 15, 2018

From what I've seen so far this is like an intermediate layer which isn't useful. For example click on Change priority menu item -> sets a hidden form field, then calls fireEvent() to trigger the onChange event handler.

The handling function can be executed directly when clicking the UI element.

asankov added a commit to asankov/Kiwi that referenced this issue Feb 16, 2020
because it is no longer used.
Refs kiwitcms#431
asankov added a commit to asankov/Kiwi that referenced this issue Feb 18, 2020
because it is no longer used.
Refs kiwitcms#431
atodorov added a commit that referenced this issue Feb 18, 2020
because it is no longer used.
Refs #431
atodorov added a commit that referenced this issue Nov 8, 2020
- after v8.8 these are now unused
- Closes #212 b/c there are no more legacy `jQ` references
- Closes #1382 b/c there are no more legacy `jQ.bind` references
- Closes #431 b/c there are no more references to `fireEvent()`
atodorov added a commit that referenced this issue Nov 9, 2020
- after v8.8 these are now unused
- Closes #212 b/c there are no more legacy `jQ` references
- Closes #1382 b/c there are no more legacy `jQ.bind` references
- Closes #431 b/c there are no more references to `fireEvent()`
atodorov added a commit that referenced this issue Nov 20, 2020
- after v8.8 these are now unused
- Closes #212 b/c there are no more legacy `jQ` references
- Closes #1382 b/c there are no more legacy `jQ.bind` references
- Closes #431 b/c there are no more references to `fireEvent()`
atodorov added a commit that referenced this issue Dec 1, 2020
- after v8.8 these are now unused
- Closes #212 b/c there are no more legacy `jQ` references
- Closes #1382 b/c there are no more legacy `jQ.bind` references
- Closes #431 b/c there are no more references to `fireEvent()`
@atodorov atodorov closed this in 5394a9d Dec 1, 2020
asankov added a commit to asankov/Kiwi that referenced this issue Dec 2, 2020
- after v8.8 these are now unused
- Closes kiwitcms#212 b/c there are no more legacy `jQ` references
- Closes kiwitcms#1382 b/c there are no more legacy `jQ.bind` references
- Closes kiwitcms#431 b/c there are no more references to `fireEvent()`
asankov added a commit to asankov/Kiwi that referenced this issue Dec 2, 2020
- after v8.8 these are now unused
- Closes kiwitcms#212 b/c there are no more legacy `jQ` references
- Closes kiwitcms#1382 b/c there are no more legacy `jQ.bind` references
- Closes kiwitcms#431 b/c there are no more references to `fireEvent()`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants