New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot change user #489

Closed
okainov opened this Issue Aug 24, 2018 · 6 comments

Comments

Projects
None yet
2 participants
@okainov
Contributor

okainov commented Aug 24, 2018

I\m getting this error when trying to save user from admin panel. Tried to set up this setting to False, but then I'm gettting 404 on /admin/auth/user/16/change/b
Searching thru code didn't reall help in it...

Kiwi baseline is from this commit 531bc99

image

@atodorov

This comment has been minimized.

Show comment
Hide comment
@atodorov

atodorov Aug 26, 2018

Member

Post a traceback and steps to reproduce.

Member

atodorov commented Aug 26, 2018

Post a traceback and steps to reproduce.

@okainov

This comment has been minimized.

Show comment
Hide comment
@okainov

okainov Aug 26, 2018

Contributor

What kind of traceback? Where can I get it from? Isn't it the one on attached screenshot?

I described the steps - go to admin panel - select any user - edit - click "save".

Contributor

okainov commented Aug 26, 2018

What kind of traceback? Where can I get it from? Isn't it the one on attached screenshot?

I described the steps - go to admin panel - select any user - edit - click "save".

@okainov

This comment has been minimized.

Show comment
Hide comment
@okainov

okainov Aug 29, 2018

Contributor

Any update? This seem to be very High priority since it's blocking user editing!

Contributor

okainov commented Aug 29, 2018

Any update? This seem to be very High priority since it's blocking user editing!

@okainov

This comment has been minimized.

Show comment
Hide comment
@okainov

okainov Aug 29, 2018

Contributor

I even did git bisect and found commit introducing this issue: f7198ca

Contributor

okainov commented Aug 29, 2018

I even did git bisect and found commit introducing this issue: f7198ca

@okainov

This comment has been minimized.

Show comment
Hide comment
@okainov

okainov Aug 29, 2018

Contributor

And I even found an issue. You pass extra_context into form_url parameter. Please set up your linter to show this warnings as Pycharm does - it clearly states that you override change_view in a wrong way. And please add a test for this functionality.

Contributor

okainov commented Aug 29, 2018

And I even found an issue. You pass extra_context into form_url parameter. Please set up your linter to show this warnings as Pycharm does - it clearly states that you override change_view in a wrong way. And please add a test for this functionality.

@atodorov

This comment has been minimized.

Show comment
Hide comment
@atodorov

atodorov Aug 29, 2018

Member

I can't reproduce with master so unless you can reproduce there or give me more info and a traceback there isn't anything I can do.

And I even found an issue. You pass extra_context into form_url parameter. Please set up your linter to show this warnings as Pycharm does - it clearly states that you override change_view in a wrong way. And please add a test for this functionality.

I'm not exactly certain what you are talking about here. KiwiUserAdmin doesn't have a change_view() method.

Member

atodorov commented Aug 29, 2018

I can't reproduce with master so unless you can reproduce there or give me more info and a traceback there isn't anything I can do.

And I even found an issue. You pass extra_context into form_url parameter. Please set up your linter to show this warnings as Pycharm does - it clearly states that you override change_view in a wrong way. And please add a test for this functionality.

I'm not exactly certain what you are talking about here. KiwiUserAdmin doesn't have a change_view() method.

atodorov added a commit that referenced this issue Sep 3, 2018

@atodorov atodorov closed this in a1a90c8 Sep 3, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment