New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate removal of labels from form fields #652

Open
atodorov opened this Issue Dec 6, 2018 · 0 comments

Comments

Projects
None yet
1 participant
@atodorov
Copy link
Member

atodorov commented Dec 6, 2018

In many places in the code we have form fields with a label attribute. For example label="Plan name",

Many of these label attributes are not used on the front-end b/c templates specify the label by hand. OTOH there are templates that use the labels and this means we have no translations for such labels.

The preferred solution is to remove the labels from the Python code and have them as translatable strings in templates.

TODO:

  • Investigate if labels are somehow used by forms not shown in the UI (e.g. used in API handlers for data validation). If they aren't used in any way we can safely remove them
  • Need to create a pylint plugin to detect all of these labels and inform us when we break this rule.

@atodorov atodorov added the refactoring label Dec 6, 2018

asankov added a commit to asankov/Kiwi that referenced this issue Dec 31, 2018

asankov added a commit to asankov/Kiwi that referenced this issue Jan 1, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment