Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename all RPC related classes from XMLRPC* to RPC #682

Open
asankov opened this issue Jan 2, 2019 · 2 comments

Comments

@asankov
Copy link
Member

commented Jan 2, 2019

Currently, a lot of our classes are prefixed with XMLRPC*. However, we support both XML-RPC and JSON-RPC. Both APIS use the same logic, so all of these classes names are misleading.

A good approach would be to implement a pylint plugin for this to enforce the convention and drive the change

@nikalas004

This comment has been minimized.

Copy link

commented Aug 8, 2019

I found the following occurrences. Is it ok if I rename them.

kolyo@kolyo-Latitude-E4310:~/Kiwi$ grep -r "class XMLRPC" *
tcms/testruns/forms.py:class XMLRPCNewRunForm(BaseRunForm):
tcms/testruns/forms.py:class XMLRPCUpdateRunForm(XMLRPCNewRunForm):
tcms/testruns/forms.py:class XMLRPCNewExecutionForm(BaseCaseRunForm):
tcms/testruns/forms.py:class XMLRPCUpdateExecutionForm(BaseCaseRunForm):
tcms/xmlrpc/forms.py:class XMLRPCCheckboxInput(CheckboxInput):
tcms/xmlrpc/serializer.py:class XMLRPCSerializer:
tcms/testcases/forms.py:class XMLRPCBaseCaseForm(BaseCaseForm):
tcms/testcases/forms.py:class XMLRPCNewCaseForm(XMLRPCBaseCaseForm):
tcms/testcases/forms.py:class XMLRPCUpdateCaseForm(XMLRPCBaseCaseForm):
@atodorov

This comment has been minimized.

Copy link
Member

commented Sep 16, 2019

Note: renaming tcms/xmlrpc/ to tcms/rpc/ or even just tcms/api/ will help with false pylint errors b/c this module conflicts with the xmlrpc module coming from the standard library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.