Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing permission check in runs/get_case_runs.html template #716

Open
atodorov opened this issue Jan 16, 2019 · 0 comments

Comments

Projects
None yet
2 participants
@atodorov
Copy link
Member

commented Jan 16, 2019

The blue buttons (menus really) on the main test run page are shown even if the user is not logged in or doesn't have the necessary permissions because the template doesn't check them at all.

For every one of the blue button we need to figure out which permission is needed:

  • For actions that directly modify the TestRun object this is testruns.change_testrun
  • For actions that modify other objects (like ManyToMany fields these are different)
  • Status buttons and comments seem to be fine however tests are needed for all of these areas.

@ivo0126 because you did the exploratory testing you get to fix this!

ivo0126 added a commit to ivo0126/Kiwi that referenced this issue Jan 27, 2019

ivo0126 added a commit to ivo0126/Kiwi that referenced this issue Feb 7, 2019

ivo0126 added a commit to ivo0126/Kiwi that referenced this issue Feb 7, 2019

ivo0126 added a commit to ivo0126/Kiwi that referenced this issue Feb 11, 2019

ivo0126 added a commit to ivo0126/Kiwi that referenced this issue Feb 19, 2019

ivo0126 added a commit to ivo0126/Kiwi that referenced this issue Feb 21, 2019

@atodorov atodorov added the security label Mar 19, 2019

ivo0126 added a commit to ivo0126/Kiwi that referenced this issue Mar 24, 2019

ivo0126 added a commit to ivo0126/Kiwi that referenced this issue May 11, 2019

ivo0126 added a commit to ivo0126/Kiwi that referenced this issue May 18, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.