Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new linter: do not use AutoField #737

Closed
atodorov opened this issue Jan 23, 2019 · 0 comments

Comments

Projects
None yet
1 participant
@atodorov
Copy link
Member

commented Jan 23, 2019

We do have lots of models which include AutoField(primary_key=True). Sometimes they are named id (like Django will do by default). Other times the column name is different.

There is no point in having these fields defined in models because Django will add them automatically. See example at https://stackoverflow.com/questions/25205228/django-autofield-with-primary-key-vs-default-pk

We need a checker class for kiwi_lint that will discover all of these AutoFields and help us get rid of them!

Ivo-Donchev added a commit to Ivo-Donchev/Kiwi that referenced this issue May 27, 2019

@atodorov atodorov closed this in 92032c5 May 28, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.