Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new linter: Do not use label in form fields #738

Open
atodorov opened this issue Jan 23, 2019 · 0 comments

Comments

@atodorov
Copy link
Member

commented Jan 23, 2019

Our team has decided that template labels must be placed in the HTML and not defined in form fields. Most of the existing ones are not translated and many of them may not be used b/c the HTML template has its own opinion. Since the HTML is what the user sees we prefer all labels to be in the HTML, not in the python code.

A kiwi_lint/ checker is needed to discover all label arguments to form field classes and warn about them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.