New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comment should be optional for test case run #77

Closed
okainov opened this Issue Oct 27, 2017 · 2 comments

Comments

Projects
None yet
2 participants
@okainov
Contributor

okainov commented Oct 27, 2017

Description of problem

Cannot set test case run status without a comment

Component (web, API, etc)

web

Version or commit hash (if applicable)

04ee633

How often reproducible

Always

Steps to Reproduce

  1. Create test-pan-case-run
  2. Go to test run
  3. Go to test case run
  4. For test case run, click icon with result status (i.e. green OK checkbox)

Actual results

Error "Please fill out this field" appear near "Comments"
Numbers in upper statistics table were changed
image

Expected results

Status should be recorded either w\o comment if it's empty or with comment, if it's not empty.
Numbers in upper table should be changed only in case when actual status change was performed.

Additional info

Possible solution - make it optional only for "Success" status

@atodorov atodorov added the confirmed label Oct 27, 2017

@atodorov

This comment has been minimized.

Show comment
Hide comment
@atodorov

atodorov Oct 27, 2017

Member

I will look at the status table issue, looks like a bug.

I'm still not sure if we want to make comments optional. If they are optional there will be people who simply set the status and forget/don't bother to comment even on failure. I've seen people do this on a regular basis. Then it becomes impossible to figure out what went wrong unless you talk to them or read the bug reports.

Member

atodorov commented Oct 27, 2017

I will look at the status table issue, looks like a bug.

I'm still not sure if we want to make comments optional. If they are optional there will be people who simply set the status and forget/don't bother to comment even on failure. I've seen people do this on a regular basis. Then it becomes impossible to figure out what went wrong unless you talk to them or read the bug reports.

@okainov

This comment has been minimized.

Show comment
Hide comment
@okainov

okainov Oct 28, 2017

Contributor

Right, that's what I mentioned in "Additional info". Maybe it makes sense to improve the behavior:

  • For "Passed" status - no comment should be required. Sounds logical - it's fine, what else do you need?
  • For other statuses - comment is required to explain, why this status was set.

"Failed" is discussible, since there is "Bugs" field, so if tester submits a bug, what else should he\she write in comment? "Test failed, see issue QQQ-1"?

Contributor

okainov commented Oct 28, 2017

Right, that's what I mentioned in "Additional info". Maybe it makes sense to improve the behavior:

  • For "Passed" status - no comment should be required. Sounds logical - it's fine, what else do you need?
  • For other statuses - comment is required to explain, why this status was set.

"Failed" is discussible, since there is "Bugs" field, so if tester submits a bug, what else should he\she write in comment? "Test failed, see issue QQQ-1"?

atodorov added a commit that referenced this issue Nov 2, 2017

Make comments optional. Fixes #77
when updating a case-run status comments are optional. However the
form HTML was displaying required="" and the validation error
reported in Issue #77 is generated on the browser side.

This commit explicitly sets the required attribute to False!

@atodorov atodorov closed this in 08491f3 Nov 2, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment