Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new linter: Extend MissingPermissionsChecker to search for tests #883

Open
atodorov opened this issue Mar 29, 2019 · 1 comment

Comments

@atodorov
Copy link
Member

commented Mar 29, 2019

We are going to figure out a naming convention for test classes that deal with permissions and then extend/add new checker class that searches for these tests. This will allow us to find places in the code for which we are missing tests along with the missing permissions.

Maybe we need to have the permission decorator first so that the test checker can explicitly search only for tests for the listed permissions!

@atodorov

This comment has been minimized.

Copy link
Member Author

commented Jul 31, 2019

Note:
As seen in #1032 (comment)

we can actually make this checker parse the function/class body and search for .save()/.delete() methods. If we're only doing filtering then no permissions are required and we can safely drop the pylint disable comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.