Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove tcms.core.contrib.comments.utils.add_comment #959

Closed
atodorov opened this issue Jun 6, 2019 · 0 comments
Closed

Remove tcms.core.contrib.comments.utils.add_comment #959

atodorov opened this issue Jun 6, 2019 · 0 comments
Labels

Comments

@atodorov
Copy link
Member

@atodorov atodorov commented Jun 6, 2019

From the discussion in #946:

add_comment from tcms.core.contrib.comments.utils is used in

  • tcms.core.contrib.comments.views, which in turn is called in static/js/tcms_actions.js - submitComment() and in some tests. There is a TODO comment which says to remove it.

OTOH there is also tcms.core.helper.comments.add_comment() which is used in

  • testruns/tests/test_data.py and xmlrpc/api/testexecution.py

The two are slightly different so we need to figure out a strategy to remove the method from core.contrib.comments.utils. I think the FE could use the API but we need to find all places where comments can be added and see how they operate first.

@atodorov atodorov added the refactoring label Jun 6, 2019
atodorov added a commit that referenced this issue Nov 24, 2019
replaces a view which we don't really need and want to delete
so we can unblock #959
atodorov added a commit that referenced this issue Nov 24, 2019
replaces a view which we don't really need and want to delete
so we can unblock #959
atodorov added a commit that referenced this issue Nov 24, 2019
replaces a view which we don't really need and want to delete
so we can unblock #959
atodorov added a commit that referenced this issue Nov 24, 2019
also updated the HTML form and removes unused CSS
atodorov added a commit that referenced this issue Nov 24, 2019
- all comment operations have been converted to JSON-RPC.
- the core.contrib.comments app provided some customizations
  over the stock django_comments app, namely the comments form,
  however none of this is used since the migration to JSON-RPC
atodorov added a commit that referenced this issue Nov 24, 2019
also updated the HTML form and removes unused CSS
@atodorov atodorov closed this in 14af8aa Nov 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.