Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert comment views/functions to class based views #960

Closed
atodorov opened this issue Jun 6, 2019 · 0 comments
Closed

Convert comment views/functions to class based views #960

atodorov opened this issue Jun 6, 2019 · 0 comments
Labels

Comments

@atodorov
Copy link
Member

@atodorov atodorov commented Jun 6, 2019

From the discussion in #946

After #959 is resolved then we need to figure out what views are left that deal with comments and convert them to class based views.

Then work on tests and permissions coverage. Once we get to that we can split it into a separate issue. CC @SvetlomirBalevski.

Update: this references tcms/core/contrib/comments/views.py

@atodorov atodorov added the refactoring label Jun 6, 2019
atodorov added a commit that referenced this issue Nov 24, 2019
replaces a view which we don't really need and want to delete
so we can unblock #959
atodorov added a commit that referenced this issue Nov 24, 2019
atodorov added a commit that referenced this issue Nov 24, 2019
replaces a view which we don't really need and want to delete
so we can unblock #959
atodorov added a commit that referenced this issue Nov 24, 2019
atodorov added a commit that referenced this issue Nov 24, 2019
replaces a view which we don't really need and want to delete
so we can unblock #959
atodorov added a commit that referenced this issue Nov 24, 2019
atodorov added a commit that referenced this issue Nov 24, 2019
also updated the HTML form and removes unused CSS
atodorov added a commit that referenced this issue Nov 24, 2019
also updated the HTML form and removes unused CSS
@atodorov atodorov closed this in 24ef434 Nov 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.