New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: Remove XmlRpcLog() model #436

Merged
merged 1 commit into from Jul 23, 2018

Conversation

Projects
None yet
3 participants
@atodorov
Member

atodorov commented Jul 18, 2018

Kiwi TCMS will no longer log RPC calls to the database. We feel
like this is not very useful and it adds a small performance penalty.

We can document how to do custom logging separately or if many people
are using this functionality then it can be reverted back!

I'm leaving this here for about 10 days if anyone is interested in commenting.

@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Jul 18, 2018

Codecov Report

Merging #436 into master will decrease coverage by 0.09%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #436     +/-   ##
=========================================
- Coverage   63.14%   63.05%   -0.1%     
=========================================
  Files         124      121      -3     
  Lines        7899     7833     -66     
  Branches     1140     1134      -6     
=========================================
- Hits         4988     4939     -49     
+ Misses       2592     2579     -13     
+ Partials      319      315      -4
Impacted Files Coverage Δ
tcms/urls.py 78.12% <ø> (ø) ⬆️
tcms/settings/common.py 96.22% <ø> (-0.07%) ⬇️
tcms/xmlrpc/api/env_group.py 57.14% <0%> (-14.29%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c75b047...5d83985. Read the comment docs.

codecov-io commented Jul 18, 2018

Codecov Report

Merging #436 into master will decrease coverage by 0.09%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #436     +/-   ##
=========================================
- Coverage   63.14%   63.05%   -0.1%     
=========================================
  Files         124      121      -3     
  Lines        7899     7833     -66     
  Branches     1140     1134      -6     
=========================================
- Hits         4988     4939     -49     
+ Misses       2592     2579     -13     
+ Partials      319      315      -4
Impacted Files Coverage Δ
tcms/urls.py 78.12% <ø> (ø) ⬆️
tcms/settings/common.py 96.22% <ø> (-0.07%) ⬇️
tcms/xmlrpc/api/env_group.py 57.14% <0%> (-14.29%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c75b047...5d83985. Read the comment docs.

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Jul 18, 2018

Pull Request Test Coverage Report for Build 1314

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.1%) to 62.299%

Totals Coverage Status
Change from base Build 1304: -0.1%
Covered Lines: 5251
Relevant Lines: 7833

💛 - Coveralls

coveralls commented Jul 18, 2018

Pull Request Test Coverage Report for Build 1314

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.1%) to 62.299%

Totals Coverage Status
Change from base Build 1304: -0.1%
Covered Lines: 5251
Relevant Lines: 7833

💛 - Coveralls
Remove XmlRpcLog() model
Kiwi TCMS will no longer log RPC calls to the database. We feel
like this is not very useful and it adds a small performance penalty.

We can document how to do custom logging separately or if many people
are using this functionality then it can be reverted back!
@atodorov

This comment has been minimized.

Show comment
Hide comment
@atodorov

atodorov Jul 23, 2018

Member

I am merging this change b/c we don't need it in the core application and it can be easily implemented on top of the existing app. I'm going to add a blog post how to do that.

Member

atodorov commented Jul 23, 2018

I am merging this change b/c we don't need it in the core application and it can be easily implemented on top of the existing app. I'm going to add a blog post how to do that.

@atodorov atodorov merged commit ec06db0 into master Jul 23, 2018

7 checks passed

Sider No issues found!
Details
codeclimate 2 fixed issues
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.4%) to 62.299%
Details
pyup.io/safety-ci No dependencies with known security vulnerabilities.
Details
security/snyk - package.json (atodorov) No manifest changes detected

@atodorov atodorov deleted the remove_xmlrpc_logging branch Jul 23, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment