Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AutoField pylint checker #949

Merged
merged 1 commit into from May 28, 2019

Conversation

Projects
None yet
4 participants
@Ivo-Donchev
Copy link
Contributor

commented May 21, 2019

No description provided.

@Ivo-Donchev

This comment has been minimized.

Copy link
Contributor Author

commented May 21, 2019

This PR introduces sollution for #737

@coveralls

This comment has been minimized.

Copy link

commented May 21, 2019

Pull Request Test Coverage Report for Build 3252

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 73.789%

Totals Coverage Status
Change from base Build 3249: 0.0%
Covered Lines: 3707
Relevant Lines: 4764

💛 - Coveralls
@atodorov
Copy link
Member

left a comment

LGTM, minor changes required.

Squash the 2 commits together and use Fixes #737 in the commit log so GitHub can close the issue automatically.

Show resolved Hide resolved kiwi_lint/auto_field.py Outdated

@atodorov atodorov referenced this pull request May 23, 2019

Closed

Add OneToOneFieldChecker #950

@codecov-io

This comment has been minimized.

Copy link

commented May 27, 2019

Codecov Report

Merging #949 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #949   +/-   ##
=======================================
  Coverage   73.15%   73.15%           
=======================================
  Files         112      112           
  Lines        4764     4764           
  Branches      609      609           
=======================================
  Hits         3485     3485           
  Misses       1057     1057           
  Partials      222      222

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 39dc1a3...8aba31d. Read the comment docs.

@Ivo-Donchev Ivo-Donchev force-pushed the Ivo-Donchev:auto-field-pylint-checker branch from f6df4df to 8aba31d May 27, 2019

@atodorov atodorov merged commit 92032c5 into kiwitcms:master May 28, 2019

8 checks passed

Scrutinizer Analysis: 2 updated code elements – Tests: passed
Details
Sider No issues found!
Details
codeclimate All good!
Details
codeclimate/diff-coverage 100% (50% threshold)
Details
codeclimate/total-coverage 77% (0.0% change)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 73.789%
Details
security/snyk - tcms/package.json (atodorov) No manifest changes detected
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.