Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add EmptyClassChecker #952

Merged
merged 1 commit into from May 28, 2019

Conversation

Projects
None yet
4 participants
@danibanani1
Copy link
Contributor

commented May 21, 2019

This PR addresses issue #739

@coveralls

This comment has been minimized.

Copy link

commented May 21, 2019

Pull Request Test Coverage Report for Build 3250

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 73.789%

Totals Coverage Status
Change from base Build 3249: 0.0%
Covered Lines: 3707
Relevant Lines: 4764

💛 - Coveralls
@codecov-io

This comment has been minimized.

Copy link

commented May 21, 2019

Codecov Report

Merging #952 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #952   +/-   ##
=======================================
  Coverage   73.15%   73.15%           
=======================================
  Files         112      112           
  Lines        4764     4764           
  Branches      609      609           
=======================================
  Hits         3485     3485           
  Misses       1057     1057           
  Partials      222      222

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b113076...e28e176. Read the comment docs.

@codecov-io

This comment has been minimized.

Copy link

commented May 21, 2019

Codecov Report

Merging #952 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #952   +/-   ##
=======================================
  Coverage   73.15%   73.15%           
=======================================
  Files         112      112           
  Lines        4764     4764           
  Branches      609      609           
=======================================
  Hits         3485     3485           
  Misses       1057     1057           
  Partials      222      222

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 39dc1a3...e02489a. Read the comment docs.

@atodorov
Copy link
Member

left a comment

Checker looks good but needs adjustments so it fits with the latest merged/proposed changes.

Also add Fixes #739 in commit log and GitHub will close the issue automatically upon merging.

Show resolved Hide resolved kiwi_lint/__init__.py
Show resolved Hide resolved kiwi_lint/empty_class.py Outdated
Show resolved Hide resolved kiwi_lint/empty_class.py Outdated

@danibanani1 danibanani1 force-pushed the danibanani1:empty-class-checker branch from e28e176 to e02489a May 27, 2019

if not node.body:
self.add_message('remove-empty-class', node=node)

for child in node.body:

This comment has been minimized.

Copy link
@atodorov

atodorov May 28, 2019

Member

FTR this is slightly incorrect b/c it will produce a pylint error also for classes which contain pass somewhere in the class body even if there are other attributes. However that is also probably an error (left over) so we should be fine.

@atodorov atodorov merged commit 5289694 into kiwitcms:master May 28, 2019

8 checks passed

Scrutinizer Analysis: 1 updated code elements – Tests: passed
Details
Sider No issues found!
Details
codeclimate All good!
Details
codeclimate/diff-coverage 100% (50% threshold)
Details
codeclimate/total-coverage 77% (0.0% change)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 73.789%
Details
security/snyk - tcms/package.json (atodorov) No manifest changes detected
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.