Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for build-custom-app #1218

Closed
kelson42 opened this issue Jun 26, 2017 · 8 comments · Fixed by #1597
Closed

Fixes for build-custom-app #1218

kelson42 opened this issue Jun 26, 2017 · 8 comments · Fixed by #1597
Assignees
Labels
custom apps Supporting the design & development of custom apps
Milestone

Comments

@kelson42
Copy link
Collaborator

  • Explain how to install ruby
  • Explain how to install travis (the travis doc is big)
  • Talk about "hash -r"
  • Put a word about "kiwix-android-custom" that people know where to modify things
  • zim_url and zim_content should be merged (in zim?)
  • remove version_code fron info.json
  • add httpslib2 in the deps
  • add google-api-python-client in the deps
  • add space before "if you found it"
@kelson42 kelson42 self-assigned this Jun 27, 2017
@kelson42
Copy link
Collaborator Author

I have started to put improvments on the Wiki page.

@kelson42 kelson42 transferred this issue from kiwix/kiwix-build Jun 24, 2019
@kelson42 kelson42 added this to the 3.0 milestone Jun 26, 2019
@kelson42
Copy link
Collaborator Author

Putting in 3.0. I think all of this will become depracated one time the publication will be automated... but this has to be checked then

@kelson42 kelson42 modified the milestones: 3.0, 3.1 Jul 29, 2019
@kelson42 kelson42 added the custom apps Supporting the design & development of custom apps label Aug 31, 2019
@kelson42
Copy link
Collaborator Author

kelson42 commented Oct 23, 2019

@macgills Tell me when you start to define in detail the new worflow, those points are still valid imo. I guess many of the points are invalid as we have moved from Python to Kotlin/Gradle... but probably not all of them.

@kelson42
Copy link
Collaborator Author

@macgills Here is a reminder about this ticket as you are polishing new custom app publishing process.

@macgills
Copy link
Contributor

I would say none of these points are still valid?

@kelson42
Copy link
Collaborator Author

@macgills The stuff with the version_code and version_name seems to be handled already with #36. But what about merging zim_url and zim_file (they can be contradictory) and are confusing!?

@macgills
Copy link
Contributor

We only need zimUrl, zimFile doesn't exist. If we need a zimFile (eg when uploading an expansion file) we download it during the build process.
We do not support embedded zims at this time. Pending the necessary update to kiwixlib we can enhance the solution

@kelson42 kelson42 assigned kelson42 and unassigned macgills Nov 20, 2019
@ghost ghost deleted a comment from kelson42 Nov 20, 2019
@ghost
Copy link

ghost commented Nov 20, 2019

This issue was moved by kelson42 to kiwix/kiwix-android-custom#40.

@ghost ghost closed this as completed Nov 20, 2019
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
custom apps Supporting the design & development of custom apps
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants