Fix Crash u_SetDictionary with LibraryViewModel multi-instance state #868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kelson42
force-pushed
the
852-crash-340-kiwix-u_setdatadirectory_73-+-48
branch
from
8e5d166
to
9106677
Compare
kelson42
force-pushed
the
852-crash-340-kiwix-u_setdatadirectory_73-+-48
branch
from
9106677
to
ec19c66
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #852
Issue
The underlying parsing should be run only once at a time. If run from multiple threads at the same time it will crash as described in the issue.
Since we have 2 instances of the
LibraryViewModel(one for the UI parts, one for background jobs - auto refresh), it was possible to crash in very rare cases, where the auto refresh kicked in the same time as a manual refresh.Solution
store the progress state in a single place, and secure it for multi-threaded access.