Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Consider not compiling jQuery into kiwix-serve? #249
After a bit of debugging, I realized that kiwix-serve contains all of the jQuery JS and CSS in the binary itself.
This is somewhat problematic from a Debian packaging perspective, mostly because if we want to change the JS code, it requires recompiling kiwix-serve.
A little background, Debian would prefer it (though it's not a hard requirement) if packages used the packaged version of jQuery and jQuery UI, just like any other library dependency. But if we have to recompile kiwix-serve every time, that's pretty problematic.
Could kiwix-serve look for the JS resources in
If there's a specific reason that the bundled jquery/jquery-ui need to be used, I can figure out a different approach that way as well.
JQuery is only used for its autocomplete function to provide input completion on the searchbar.
I'm a bit afraid to be dependent of a files installed outwhere in the system. It would lead to the kiwix-tools package being dependent of jQuery package (and the kiwx-tools project not being dependent of jQuery).
To me changing the library is just a workaround. I would stick to JQuery. It is quite clear anyway that this page (and the searchbar) will be rewritten anyway soon. Regarding the dependency to jquery, it is like any other dependence, it has to be there and the packaging system should secure this. That said, I would prefer that we do not touch this for now, IMO this is quite a bit of work, it is not the best moment and it seems not to be 100% mandatory. @legoktm Could you live with the current situation for now?