Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better document API changes #985

Closed
kelson42 opened this issue Jul 27, 2023 · 4 comments
Closed

Better document API changes #985

kelson42 opened this issue Jul 27, 2023 · 4 comments
Assignees
Milestone

Comments

@kelson42
Copy link
Collaborator

kelson42 commented Jul 27, 2023

We regularly face situations where the lack of clarity around API changes (and this is true as well for libzim) leads us to uncontrolled movements:

  • we don’t follow anymore sementic versionning and this leads to further problem with linux distros
  • Responsible of binding don’t do the necessary changes
  • Users of the library are not informed properly about new features

what can we do to fix these problems.

@mgautierfr
Copy link
Member

We should introduce a tool like https://lvc.github.io/abi-compliance-checker/ in our CI to detect a ABI change as soon as possible.

@kelson42
Copy link
Collaborator Author

@mgautierfr Seems indeed a good security. I have found as well https://github.com/lvc/abi-compliance-checker but seems not maintained.

... But the other point might be the communication, in particular at release time. Could we have an easy and standard way to communicate these changes?

@mgautierfr
Copy link
Member

... But the other point might be the communication, in particular at release time. Could we have an easy and standard way to communicate these changes?

We have, this is semantic versioning we already follow (except when we don't realize ourselves we break the API)

@kelson42
Copy link
Collaborator Author

Update:

  • there is no easy way to deploy a tool to check this (no action, old tool to configure, …)
  • We have updated the dependencies (kiwix-tools, kiwix-desktop) to not accept new major dependencies per default
  • I have updated the release check list to verify if we don‘t have missed a breaking ABI change

At this stage, I believe there is nothing much more we can reasonably do.

@kelson42 kelson42 closed this as not planned Won't fix, can't repro, duplicate, stale May 12, 2024
@kelson42 kelson42 self-assigned this May 12, 2024
@kelson42 kelson42 added the task label May 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants