From 743700505ff0cb02b683536c4ebbfa89029b9a32 Mon Sep 17 00:00:00 2001 From: kiyu-git <47422498+kiyu-git@users.noreply.github.com> Date: Thu, 21 Aug 2025 00:07:41 +0900 Subject: [PATCH 1/5] =?UTF-8?q?fix:=20=E4=BF=AE=E6=AD=A3=E9=8C=B2=E7=94=BB?= =?UTF-8?q?=E5=81=9C=E6=AD=A2=E6=99=82=E3=81=AE=E3=83=95=E3=83=A9=E3=82=B0?= =?UTF-8?q?=E8=A8=AD=E5=AE=9A=E3=81=A8DataViewer=E3=81=AE=E4=BE=9D?= =?UTF-8?q?=E5=AD=98=E9=85=8D=E5=88=97=E3=82=92=E6=9B=B4=E6=96=B0?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- src/main/electron-src/lib/serialManager.js | 2 +- src/renderer/components/DataPlot.tsx | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/main/electron-src/lib/serialManager.js b/src/main/electron-src/lib/serialManager.js index b0bc9a4..c8cfd19 100644 --- a/src/main/electron-src/lib/serialManager.js +++ b/src/main/electron-src/lib/serialManager.js @@ -175,7 +175,7 @@ class DataRecorder { }; stopRecord = () => { - this.shouldRecord = true; + this.shouldRecord = false; }; } diff --git a/src/renderer/components/DataPlot.tsx b/src/renderer/components/DataPlot.tsx index b6c1c6c..2ccce53 100644 --- a/src/renderer/components/DataPlot.tsx +++ b/src/renderer/components/DataPlot.tsx @@ -115,7 +115,7 @@ export default function DataViewer() { } setState(updateLines); } - }, [newData, state]); // Added state to dependency array + }, [newData]); // Added state to dependency array return ( <> From 8025afc161baf2b52eb94178a3b8d3d170f6aab0 Mon Sep 17 00:00:00 2001 From: kiyu-git <47422498+kiyu-git@users.noreply.github.com> Date: Thu, 21 Aug 2025 00:14:21 +0900 Subject: [PATCH 2/5] feat: Add serialport build steps for armv7l in CI --- .github/workflows/publish-armv7l.yml | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/.github/workflows/publish-armv7l.yml b/.github/workflows/publish-armv7l.yml index 34b7def..b45c479 100644 --- a/.github/workflows/publish-armv7l.yml +++ b/.github/workflows/publish-armv7l.yml @@ -27,15 +27,22 @@ jobs: with: node-version: 18 cache: npm - + + - name: Install node-gyp and node-pre-gyp + run: sudo npm install -g node-gyp node-pre-gyp + - name: Setup Python uses: actions/setup-python@v2 with: - python-version: '3.10' + python-version: '3.10' - name: Install and build run: | npm install + # Build serialport for armv7l + cd node_modules/@serialport/bindings-cpp + sudo node-gyp configure build + cd ../../../ npm run postinstall npm run build From 0d99c7d8d63fa060831b365926c8f7e7f79b26c1 Mon Sep 17 00:00:00 2001 From: kiyu-git <47422498+kiyu-git@users.noreply.github.com> Date: Thu, 21 Aug 2025 00:30:50 +0900 Subject: [PATCH 3/5] =?UTF-8?q?fix:=20=E4=BF=AE=E6=AD=A3armv7l=E3=83=93?= =?UTF-8?q?=E3=83=AB=E3=83=89=E3=81=AE=E3=83=91=E3=82=B9=E3=82=92=E6=9B=B4?= =?UTF-8?q?=E6=96=B0?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .github/workflows/publish-armv7l.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/publish-armv7l.yml b/.github/workflows/publish-armv7l.yml index b45c479..ba21b9d 100644 --- a/.github/workflows/publish-armv7l.yml +++ b/.github/workflows/publish-armv7l.yml @@ -40,7 +40,7 @@ jobs: run: | npm install # Build serialport for armv7l - cd node_modules/@serialport/bindings-cpp + cd release/app/node_modules/@serialport/bindings-cpp sudo node-gyp configure build cd ../../../ npm run postinstall From 36f649d070d4ebeda298cd7096de506d513f2e87 Mon Sep 17 00:00:00 2001 From: kiyu-git <47422498+kiyu-git@users.noreply.github.com> Date: Thu, 21 Aug 2025 00:35:02 +0900 Subject: [PATCH 4/5] =?UTF-8?q?fix:=20=E4=BF=AE=E6=AD=A3serialport?= =?UTF-8?q?=E3=83=93=E3=83=AB=E3=83=89=E3=81=AE=E3=83=87=E3=82=A3=E3=83=AC?= =?UTF-8?q?=E3=82=AF=E3=83=88=E3=83=AA=E3=83=91=E3=82=B9?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .github/workflows/publish-armv7l.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/publish-armv7l.yml b/.github/workflows/publish-armv7l.yml index ba21b9d..95c3868 100644 --- a/.github/workflows/publish-armv7l.yml +++ b/.github/workflows/publish-armv7l.yml @@ -42,7 +42,7 @@ jobs: # Build serialport for armv7l cd release/app/node_modules/@serialport/bindings-cpp sudo node-gyp configure build - cd ../../../ + cd ../../../../../ npm run postinstall npm run build From 3aa7cc5b6b75edd7392ea3cd42ab26da568ef465 Mon Sep 17 00:00:00 2001 From: kiyu-git <47422498+kiyu-git@users.noreply.github.com> Date: Thu, 21 Aug 2025 01:15:57 +0900 Subject: [PATCH 5/5] =?UTF-8?q?fix:=20=E3=83=93=E3=83=AB=E3=83=89=E3=83=97?= =?UTF-8?q?=E3=83=AD=E3=82=BB=E3=82=B9=E3=82=92=E4=BF=AE=E6=AD=A3?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .github/workflows/publish-armv7l.yml | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/.github/workflows/publish-armv7l.yml b/.github/workflows/publish-armv7l.yml index 95c3868..2ca4e9b 100644 --- a/.github/workflows/publish-armv7l.yml +++ b/.github/workflows/publish-armv7l.yml @@ -28,9 +28,6 @@ jobs: node-version: 18 cache: npm - - name: Install node-gyp and node-pre-gyp - run: sudo npm install -g node-gyp node-pre-gyp - - name: Setup Python uses: actions/setup-python@v2 with: @@ -39,11 +36,11 @@ jobs: - name: Install and build run: | npm install + npm run postinstall # Build serialport for armv7l cd release/app/node_modules/@serialport/bindings-cpp - sudo node-gyp configure build - cd ../../../../../ - npm run postinstall + npx node-gyp configure build + cd - npm run build - name: Publish releases