YSF support prototype #376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
kk7ds
commented
Jan 11, 2023
kk7ds
commented
- Add DN to mode list for Yaesu System Fusion
- Add DN mode support to FT1, FT2, FT3
- Make RepeaterBook return YSF (DN mode) repeaters
Related to #10242
Fixes #10242
This allows selecting only FM, DV, DMR, or DN repeaters to be returned in a RepeaterBook query. Related to #10242
A certain pattern of selecting and unselecting the band filter would cause us to apply the filter with it disabled. This fixes that and rewrites the routine to match the mode filter added previously.
This makes it easy to test for '"foo" in group'.
We need to actually re-fetch the memory from the radio after the memory properties dialog makes changes. Some settings made in that dialog could have affected other things, so just taking the result of the dialog's edits is not good enough. This also makes us schedule the set_memory() and get_memory() with do_radio() which should improve things for live radios.
This was only tested on an FT3, so it may not work for the other two, but since they're nearly identical, I think it should. The strategy here is that we consider DN the mode, which can either have AMS enabled or not. By default when DN is selected, AMS is enabled, but a mem.extra allows turning it off. Selecting FM means "I want this to be analog-only" the equivalent of FM with AMS disabled in the radio. We have no way to represent the "FM with AMS" display that the radio has, as that is based on the state of the last received transmission and not something in the memory. Related to #10242
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.