bitwise: Avoid duplicate definitions on one scope #907
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kk7ds
force-pushed
the
bitwise-dupcheck
branch
3 times, most recently
from
df2e0a6
to
6420c38
Compare
The icv80 had a duplicate entry in a bitwise scope, which caused the driver author to incorrectly use a set_raw(15) instead of 16. Also, a one-off on the number of channels was causing a negative seek, and also a few unnecessary seeks.
This makes bitwise warn about duplicate names defined in the same scope, which before resulted in loss of access to the eclipsed element. Now, an error log is emitted. There are a lot of drivers committing this crime, so I've added a test to highlight them and marked it as XFAIL for the moment. Fixes #11140
kk7ds
force-pushed
the
bitwise-dupcheck
branch
from
6420c38
to
8b3bbf0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes bitwise warn about duplicate names defined in the same
scope, which before resulted in loss of access to the eclipsed
element. Now, an error log is emitted.
There are a lot of drivers committing this crime, so I've added a
test to highlight them and marked it as XFAIL for the moment.
Fixes #11140