Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot disable Container Tabs #381

Open
concatime opened this issue Jul 12, 2019 · 7 comments
Open

Cannot disable Container Tabs #381

concatime opened this issue Jul 12, 2019 · 7 comments
Labels

Comments

@concatime
Copy link

@concatime concatime commented Jul 12, 2019

Description

When using CanvasBlocker with Firefox Developer Edition (69.0b1 on Arch), I simply cannot disable Container Tabs, which seems to be a hard dependency of CanvasBlocker.

Response from email:

CanvasBlocker does not use container tabs but supports them. If you do
not use it in Firefox CanvasBlocker will just work fine.

screenshot

Expected Behavior

Being able to disable Container Tabs.

Current Behavior

Option grayed out.

Possible Solution

?

Steps to Reproduce (for bugs)

  1. Get Firefox Developer Edition (69.0b1 on Arch)
  2. Install CanvasBlocker
  3. Try to disable Container Tabs

Your Environment

  • CanvasBlocker Version used: Version 0.5.12
  • Firefox version incl. 32- or 64-bit: Firefox Developer Edition 64-bit (69.0b1 on Arch)
  • Operating System and version (desktop or mobile): Arch Linux
@kkapsner

This comment has been minimized.

Copy link
Owner

@kkapsner kkapsner commented Jul 12, 2019

Interesting point but unfortunately there is nothing I can do. I have to use this API to support the people who use this feature (#350 and #368). We would have to open a change request at Mozilla to allow extension to use this feature and let the user disable it.

PS: this feature should be also available in Firefox 67.

@kkapsner

This comment has been minimized.

Copy link
Owner

@kkapsner kkapsner commented Jul 12, 2019

What are the down sides of having this setting on? Would these go away if you just delete all available containers?

@concatime

This comment has been minimized.

Copy link
Author

@concatime concatime commented Jul 12, 2019

When you right click on a link, there is an annoying “Open Link in New Container Tab”, which on its own has a sub-menu with Personal, Work, Banking & Shopping. Quite annoying. For now, I will use this hack until this get resolved (if…).

@spodermenpls

This comment has been minimized.

Copy link
Contributor

@spodermenpls spodermenpls commented Jul 12, 2019

These are the Bugzilla tickets concerning this issue:

https://bugzilla.mozilla.org/show_bug.cgi?id=1386673
https://bugzilla.mozilla.org/show_bug.cgi?id=1458585

Someone made a patch 7 months ago, but nothing happened since then for no apparent reason. Maybe @kkapsner can poke the right people there or take matters into his own hands, to speed up the process. 😅 I've upvoted the tickets ages ago, since I've been 'suffering' from this issue when Cookie AutoDelete introduced Container support..

@concatime Thanks for the hint of the userChrome.css entry, haven't thought about the ability to hide that annoying context menu option that way before.

@kkapsner

This comment has been minimized.

Copy link
Owner

@kkapsner kkapsner commented Jul 12, 2019

I will gladly make this permission optional.

@Gespalder

This comment has been minimized.

Copy link

@Gespalder Gespalder commented Dec 23, 2019

An extension, CanvasBlocker, requires Container Tabs.

I have them Enabled as other extensions want them (Facebook Container for example)
When I Disable any of them I still see the same message until all are Disabled.
Still a Firefox bug?

@kkapsner

This comment has been minimized.

Copy link
Owner

@kkapsner kkapsner commented Dec 23, 2019

Yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.