Add getChildPages optimization #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Looks great! As always, thanks for your contribution :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👋 @kkga
This
getChildPagesoptimization speeds up the 10k markdown file benchmark by 20-30sec on my M1 Pro.I traced the benchmark and saw we were spending 60sec in this function:
We call
getChildPagestwice per page and end up doing duplicate work (looping the other pages).This PR roughly halves the amount of time we spend in this function.
There are no performance benefits for small builds (e.g. docs).
As always, no pressure to merge this – just sharing for interest :)
Benchmark used