New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v6.9.2 breaks php parsing in vscode and atom #146
Comments
I changed the maximum number of bytes from 6 to 4 in utf-8 encoding to RFC 3629. |
Sorry, for the long delay. Is there any way to find out the cause and fix it? Is there any way I could help? |
I don't know atom-overlay, vscode-textmate etc.. I created issue_146 branch. |
Thank you for your modifications, but this didn't catch the regexp. Modifying the source further gave some results. Like you've said, Adding print before returning with Having disabled the 4-byte check I've dumped every pattern, that Digging further I caught a lot of occurrences of 2147483647 in regparse.c in
Unfortunately, at this point I have no idea how to interpret this result and what to do next. |
0x7f is a valid code in UTF-8. |
May I ask you to rephrase this? I don't get, what PHP mode is :( Is it an extension, responsible for PHP or something? |
I believe that @kkos is referring to the syntax definition used for highlighting PHP. In some editors, these are known as “modes”. At a glance, it seems that this is Atom's PHP syntax definition. You can see The problem is that \x{7fffffff} is not a valid Unicode code point, so Oniguruma won't accept the expressions. Instead, the expressions should use Why did this break? Before 6.9.2, |
Thanks @Thom1729. By the way, in the current master branch, I added ONIG_SYN_ALLOW_INVALID_CODE_END_OF_RANGE_IN_CC and enabled it in DEFAULT syntax only. |
vscode gives the following error:
atom gives a similar error
This does not happen in v6.9.1
See elprans/electron-overlay#41 for a reference
The text was updated successfully, but these errors were encountered: