Skip to content

GH-96 Postgres adapter get_column_info query fix#142

Merged
greut merged 6 commits into
jpfuentes2:masterfrom
jmoberley:issue_96
Mar 26, 2012
Merged

GH-96 Postgres adapter get_column_info query fix#142
greut merged 6 commits into
jpfuentes2:masterfrom
jmoberley:issue_96

Conversation

@jmoberley

Copy link
Copy Markdown

Fix for GH-96

@jmoberley

Copy link
Copy Markdown
Author

Merged @greut's pgsql-tests branch, added test for issue GH-96, fixed another issue with my previous commit that was returning column types incorrectly.

Thanks @greut for the help.

Comment thread test/PgsqlAdapterTest.php Outdated

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They called the tests coming from an issue after it, so test_gh68_… and you should fix the space vs tab thing to match the rest. Otherwise it seems to be a good job. Well done mate!

greut added a commit that referenced this pull request Mar 26, 2012
GH-96 Postgres adapter get_column_info query fix
@greut greut merged commit 9dbd41a into jpfuentes2:master Mar 26, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants