Fix a HiPE compiler bug evaluating an expression that throws system_l…

…imit
klacke · Feb 14, 2010 · 63c1378 · 63c1378
1 parent 9a8bcc7
commit 63c1378
Showing 1 changed file with 19 additions and 14 deletions.
diff --git a/lib/hipe/cerl/erl_bif_types.erl b/lib/hipe/cerl/erl_bif_types.erl
@@ -3128,20 +3128,25 @@ arith(Op, X1, X2) ->
 	  %% io:format("done arith ~p = ~p~n", [Op, {NewMin, NewMax}]),
 	  {ok, t_from_range(NewMin, NewMax)};
 	false ->  
-	  AllVals =
-	    case Op of
-	      '+'    -> [X + Y    || X <- L1, Y <- L2];
-	      '-'    -> [X - Y    || X <- L1, Y <- L2];
-	      '*'    -> [X * Y    || X <- L1, Y <- L2];
-	      'div'  -> [X div Y  || X <- L1, Y <- L2,Y =/= 0];
-	      'rem'  -> [X rem Y  || X <- L1, Y <- L2,Y =/= 0];
-	      'bsl'  -> [X bsl Y  || X <- L1, Y <- L2];
-	      'bsr'  -> [X bsr Y  || X <- L1, Y <- L2];
-	      'band' -> [X band Y || X <- L1, Y <- L2];
-	      'bor'  -> [X bor Y  || X <- L1, Y <- L2];
-	      'bxor' -> [X bxor Y || X <- L1, Y <- L2]
-	    end,
-	  {ok, t_integers(ordsets:from_list(AllVals))}
+	  %% Some of these arithmetic operations might throw a system_limit
+	  %% exception; for example, when trying to evaluate 1 bsl 100000000.
+	  try case Op of
+	        '+'    -> [X + Y    || X <- L1, Y <- L2];
+	        '-'    -> [X - Y    || X <- L1, Y <- L2];
+	        '*'    -> [X * Y    || X <- L1, Y <- L2];
+	        'div'  -> [X div Y  || X <- L1, Y <- L2,Y =/= 0];
+	        'rem'  -> [X rem Y  || X <- L1, Y <- L2,Y =/= 0];
+	        'bsl'  -> [X bsl Y  || X <- L1, Y <- L2];
+	        'bsr'  -> [X bsr Y  || X <- L1, Y <- L2];
+	        'band' -> [X band Y || X <- L1, Y <- L2];
+	        'bor'  -> [X bor Y  || X <- L1, Y <- L2];
+	        'bxor' -> [X bxor Y || X <- L1, Y <- L2]
+	      end of
+	    AllVals ->
+	      {ok, t_integers(ordsets:from_list(AllVals))}
+	  catch
+	    error:system_limit -> error
+	  end
       end
   end.