Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Update Makefile and src/Makefile #124

Merged
merged 1 commit into from Sep 8, 2012

Conversation

Projects
None yet
2 participants
Contributor

jj1bdx commented Sep 8, 2012

  • Targets in Makefile of yaws.plt and dialyzer calls
    dialyzer with two target directories, ebin and src;
    this causes the error of duplicate modules.
    Checking out the .beam files under ebin is sufficient
    for dialyzer; src is removed.
  • Target mime_type_c.beam in src/Makefile is
    superfluous and generates a spurious .beam file in
    the src directory, so the target is removed.
    Also target charset.def in src/Makefile should be
    dependent on ../ebin/mime_type_c.beam, so this is
    also changed from the previous target without the
    directory path.
@jj1bdx jj1bdx Update Makefile and src/Makefile
* Targets in `Makefile` of `yaws.plt` and `dialyzer` calls
  dialyzer with two target directories, `ebin` and `src`;
  this causes the error of duplicate modules.
  Checking out the .beam files under `ebin` is sufficient
  for dialyzer; `src` is removed.

* Target `mime_type_c.beam` in `src/Makefile` is
  superfluous and generates a spurious .beam file in
  the `src` directory, so the target is removed.
  Also target `charset.def` in `src/Makefile` should be
  dependent on `../ebin/mime_type_c.beam`, so this is
  also changed from the previous target without the
  directory path.
9b86f4a

@klacke klacke added a commit that referenced this pull request Sep 8, 2012

@klacke klacke Merge pull request #124 from jj1bdx/jj1bdx-dialyzer-fix
Update Makefile and src/Makefile
5f3ea37

@klacke klacke merged commit 5f3ea37 into klacke:master Sep 8, 2012

Owner

klacke commented Sep 8, 2012

thanks

Contributor

jj1bdx commented Sep 8, 2012

I think specifying the full path of the OTP libraries at the dialyzer command is redundant;
dialyzer ... --apps sasl kernel stdlib erts will be OK.

@jgrinstead jgrinstead pushed a commit to jgrinstead/yaws that referenced this pull request Apr 23, 2015

@klacke klacke Merge pull request #124 from jj1bdx/jj1bdx-dialyzer-fix
Update Makefile and src/Makefile
107be07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment