Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Update Makefile and src/Makefile #124

Merged
merged 1 commit into from

2 participants

@jj1bdx
  • Targets in Makefile of yaws.plt and dialyzer calls
    dialyzer with two target directories, ebin and src;
    this causes the error of duplicate modules.
    Checking out the .beam files under ebin is sufficient
    for dialyzer; src is removed.

  • Target mime_type_c.beam in src/Makefile is
    superfluous and generates a spurious .beam file in
    the src directory, so the target is removed.
    Also target charset.def in src/Makefile should be
    dependent on ../ebin/mime_type_c.beam, so this is
    also changed from the previous target without the
    directory path.

@jj1bdx jj1bdx Update Makefile and src/Makefile
* Targets in `Makefile` of `yaws.plt` and `dialyzer` calls
  dialyzer with two target directories, `ebin` and `src`;
  this causes the error of duplicate modules.
  Checking out the .beam files under `ebin` is sufficient
  for dialyzer; `src` is removed.

* Target `mime_type_c.beam` in `src/Makefile` is
  superfluous and generates a spurious .beam file in
  the `src` directory, so the target is removed.
  Also target `charset.def` in `src/Makefile` should be
  dependent on `../ebin/mime_type_c.beam`, so this is
  also changed from the previous target without the
  directory path.
9b86f4a
@klacke klacke merged commit 5f3ea37 into klacke:master
@klacke
Owner

thanks

@jj1bdx

I think specifying the full path of the OTP libraries at the dialyzer command is redundant;
dialyzer ... --apps sasl kernel stdlib erts will be OK.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Sep 8, 2012
  1. @jj1bdx

    Update Makefile and src/Makefile

    jj1bdx authored
    * Targets in `Makefile` of `yaws.plt` and `dialyzer` calls
      dialyzer with two target directories, `ebin` and `src`;
      this causes the error of duplicate modules.
      Checking out the .beam files under `ebin` is sufficient
      for dialyzer; `src` is removed.
    
    * Target `mime_type_c.beam` in `src/Makefile` is
      superfluous and generates a spurious .beam file in
      the `src` directory, so the target is removed.
      Also target `charset.def` in `src/Makefile` should be
      dependent on `../ebin/mime_type_c.beam`, so this is
      also changed from the previous target without the
      directory path.
This page is out of date. Refresh to see the latest.
Showing with 3 additions and 5 deletions.
  1. +2 −2 Makefile
  2. +1 −3 src/Makefile
View
4 Makefile
@@ -79,7 +79,7 @@ touch:
find . -name '*.erl' -print | xargs touch -m
yaws.plt:
- dialyzer --build_plt -r ebin src --output_plt yaws.plt \
+ dialyzer --build_plt -r ebin --output_plt yaws.plt \
-r $(ERLDIR)/lib/sasl-$(SASL_VSN) \
-r $(ERLDIR)/lib/kernel-$(KERNEL_VSN) \
-r $(ERLDIR)/lib/stdlib-$(STDLIB_VSN) \
@@ -89,7 +89,7 @@ yaws.plt:
# -r $(ERLDIR)/lib/ssl-$(SSL_VSN)
dialyzer: yaws.plt
- -dialyzer -q --plt yaws.plt -r ebin src > dialyzer_warnings
+ -dialyzer -q --plt yaws.plt -r ebin > dialyzer_warnings
diff -U0 known_dialyzer_warnings dialyzer_warnings
.PHONY: test
View
4 src/Makefile
@@ -101,9 +101,7 @@ charset.def:
echo $(DEFAULT_CHARSET) > ../priv/charset.def; \
else rm -f ../priv/charset.def ; touch ../priv/charset.def; fi
-mime_type_c.beam: mime_type_c.erl
-
-mime_types.erl: charset.def mime_type_c.beam
+mime_types.erl: charset.def ../ebin/mime_type_c.beam
$(ERL) -noshell -pa ../ebin -s mime_type_c generate
debug:
Something went wrong with that request. Please try again.