Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ?SLEEP_TIMEOUT and replace with option to pass on consumer start #4

Closed
complex64 opened this issue Jun 30, 2015 · 3 comments
Closed

Remove ?SLEEP_TIMEOUT and replace with option to pass on consumer start #4

complex64 opened this issue Jun 30, 2015 · 3 comments

Comments

@complex64
Copy link
Contributor

In inspiration of zmstone@6545022, I'd like to remove the ?SLEEP_TIMEOUT macro that is in use and replace it with an option that can be passed on consumer start.

I will prepare a pull request in the coming days.
@id
Copy link
Contributor

id commented Jun 30, 2015

Good idea.

@id
Copy link
Contributor

id commented Sep 23, 2015

Resolved in 415b717.

@id id closed this as completed Sep 23, 2015
@complex64
Copy link
Contributor Author

👍

zmstone pushed a commit to zmstone/brod that referenced this issue Feb 23, 2021
@k32
Merge pull request kafka4beam#4 from kafka4beam/run-ci-on-multiple-br…
5611f70 
…oker-versions

Run CI on different versions of the broker
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@complex64 @id