Skip to content
GitHub no longer supports this web browser. Learn more about the browsers we support.
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Encode nil as null #92

Merged
merged 3 commits into from Jan 31, 2020
Merged

Encode nil as null #92

merged 3 commits into from Jan 31, 2020

Conversation

@davydog187
Copy link
Contributor

davydog187 commented Jan 28, 2020

Fixes the encoding part of #91. I'll open another for the decoding

This is admittedly my first Erlang code ever, so I may have botched something.

Fixes #91
@coveralls

This comment has been minimized.

Copy link

coveralls commented Jan 28, 2020

Pull Request Test Coverage Report for Build 574

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 566: 0.0%
Covered Lines: 1703
Relevant Lines: 1703

💛 - Coveralls
@davydog187

This comment has been minimized.

Copy link
Contributor Author

davydog187 commented Jan 30, 2020

@zmstone do you have any feedback on this PR?

@zmstone

This comment has been minimized.

Copy link
Contributor

zmstone commented Jan 30, 2020

Look good to me.
ping @mikpe @qzhuyan @k32 for approval and merge.

@zmstone

This comment has been minimized.

Copy link
Contributor

zmstone commented Jan 30, 2020

oh, maybe update changelog.md and bump a minor.

@davydog187

This comment has been minimized.

Copy link
Contributor Author

davydog187 commented Jan 31, 2020

@zmstone I bumped the patch version and added to changelog.

CC: @mikpe @qzhuyan @k32 for review/approval

@mikpe
mikpe approved these changes Jan 31, 2020
src/avro_primitive.erl Show resolved Hide resolved
@davydog187

This comment has been minimized.

Copy link
Contributor Author

davydog187 commented Jan 31, 2020

@mikpe looks like you need to merge for me :)

Would it be possible to do a release as well?

@mikpe
mikpe approved these changes Jan 31, 2020
@mikpe mikpe merged commit ebdee67 into klarna:master Jan 31, 2020
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@mikpe

This comment has been minimized.

Copy link
Contributor

mikpe commented Jan 31, 2020

Merged and tagged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.