Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upEncode nil as null #92
Merged
+35
−1
Conversation
This comment has been minimized.
This comment has been minimized.
coveralls
commented
Jan 28, 2020
•
Pull Request Test Coverage Report for Build 574
|
This comment has been minimized.
This comment has been minimized.
|
@zmstone do you have any feedback on this PR? |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
oh, maybe update changelog.md and bump a minor. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
@mikpe looks like you need to merge for me :) Would it be possible to do a release as well? |
This comment has been minimized.
This comment has been minimized.
|
Merged and tagged. |
This was referenced Jan 31, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
davydog187 commentedJan 28, 2020
•
edited
Fixes the encoding part of #91. I'll open another for the decoding
This is admittedly my first Erlang code ever, so I may have botched something.