This repository has been archived by the owner on Mar 31, 2020. It is now read-only.
Json references #37
Closed
Json references #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| -include_lib("common_test/include/ct.hrl"). | ||
|
|
||
| -define(json_schema_draft4, <<"http://json-schema.org/draft-04/schema#">>). |
There was a problem hiding this comment.
According to Elvis:
Invalid macro name json_schema_draft4 on line 61. Use UPPER_CASE.
…dation functions.
| case jesse_lib:is_json_object(Schema) of | ||
| true -> | ||
| State1 = jesse_state:set_current_schema(State0, Schema), | ||
| State2 = jesse_schema_validator:validate_with_state(Schema, Value, State1), |
There was a problem hiding this comment.
According to Elvis:
Line 1127 is too long: State2 = jesse_schema_validator:validate_with_state(Schema, Value, State1),.
This was referenced Dec 5, 2015
Closed
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a continuation on draft 4 PR.
It also contains the previous PR with reference support.
This PR adds both local and remote references. It should follow the id-attribute as far as I know. Atleast the basic cases.