Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Quotes change to work with Windows. #233

Merged
merged 2 commits into from Apr 3, 2013

Conversation

Projects
None yet
3 participants
Contributor

tobya commented Dec 30, 2012

Provided a base git.exe template for windows users in config.ini-example
most importantly replaced single quotes with double quotes on format on call to log. This is required for windows use.

Along with another pull request to the gitter project, these 2 changes are necessary to get gitlist running properly on a windows box running Apache.

tobya added some commits Dec 30, 2012

@tobya tobya Added base for Windows user
Hint to use double quotes for Git Executible path.
Set repo base to windows path.
53326ff
@tobya tobya Changed single quote to double quote around format
This is required for use on windows.
c74258e

@marcoscoelho marcoscoelho commented on the diff Jan 3, 2013

src/GitList/Git/Repository.php
@@ -18,7 +18,7 @@ public function getPaginatedCommits($file = null, $page = 0)
{
$page = 15 * $page;
$pager = "--skip=$page --max-count=15";
- $command = "log $pager --pretty=format:'<item><hash>%H</hash><short_hash>%h</short_hash><tree>%T</tree><parent>%P</parent><author>%an</author><author_email>%ae</author_email><date>%at</date><commiter>%cn</commiter><commiter_email>%ce</commiter_email><commiter_date>%ct</commiter_date><message><![CDATA[%s]]></message></item>'";
+ $command = "log $pager --pretty=format:\"<item><hash>%H</hash><short_hash>%h</short_hash><tree>%T</tree><parent>%P</parent><author>%an</author><author_email>%ae</author_email><date>%at</date><commiter>%cn</commiter><commiter_email>%ce</commiter_email><commiter_date>%ct</commiter_date><message><![CDATA[%s]]></message></item>\"";
Contributor

tobya commented Jan 4, 2013

Ok great, ill try the latest source

@klaussilveira klaussilveira merged commit c74258e into klaussilveira:master Apr 3, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment