Correctly support branch names with slashes #259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, branches with slashes in the name would consume all slashed segments in a URL, causing the routes to capture incorrect file paths. This solution is not particularly elegant - anywhere a route used both a commit-ish identifier and a path, we collapse those two params into a single param, and parse that param inside the route. It seems to be working reasonably reliably, but has not seen extensive testing. It is also not particularly pretty. If anyone sees ways to improve it, please, have at it.
klaussilveira
added a commit
that referenced
this pull request
Feb 12, 2013
Correctly support branch names with slashes
|
It's safe for master, let's just create more test cases surrounding this feature. |
| } | ||
|
|
||
| if ($commitish === null) { | ||
| // DEBUG Can you have a repo with no branches? How should we handle |
There was a problem hiding this comment.
We should fallback to the default branch. Take a look at: #61
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #250.
Previously, branches with slashes in the name would consume all slashed
segments in a URL, causing the routes to capture incorrect file paths.
This solution is not particularly elegant - anywhere a route used
both a commit-ish identifier and a path, we collapse those two params
into a single param, and parse that param inside the route.
It seems to be working reasonably reliably, but has not seen extensive
testing.
It is also not particularly pretty. If anyone sees ways to improve it,
please, have at it.