add an option for setting the timezone in the local config.ini #336

Merged
merged 2 commits into from Sep 12, 2013

Conversation

Projects
None yet
2 participants
Contributor

plicease commented Jun 21, 2013

I'd like to be able to specify the timezone in the config.ini for this app instead of the global php.ini. Here is a proposed change that would allow that.

I understand from googleing around that the consensus "right way" to do this is to update the php.ini, but some users (myself included) may not have the authority to modify the php.ini, or it may be useful for different apps to be set to different timezones.

Owner

klaussilveira commented Jun 30, 2013

The template config.ini should also be updated, not just the code.

Contributor

plicease commented Jul 1, 2013

Updated the example config.ini.

Contributor

plicease commented Jul 19, 2013

I updated the push request to update the example config.ini as suggested.

I am wondering if there is anything else I can do to get this pull request approved or if there is something fundamentally wrong with my approach.

klaussilveira merged commit 178c1a2 into klaussilveira:master Sep 12, 2013

1 check passed

default The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment