New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

macos-build branch: segmentation faults when closing modal dialogs #51

Closed
klayoutmatthias opened this Issue Jan 2, 2018 · 3 comments

Comments

Projects
None yet
2 participants
@klayoutmatthias
Owner

klayoutmatthias commented Jan 2, 2018

Upon closing modal dialogs (like the assistant), segmentation faults are observed.

The stack trace points to a place inside the event handler, specifically the QTimerEvent handling. Apparently, some things are messed up in the menu area.

Experiments show that the menu synchronisation is causing this issue. In this step, the main menu is cleared and rebuilt from scratch. Apparently this is not allows on MacOS. Probably because of the merging of the application menu with the system menu.

Further experiments show that the issue can be avoided if remove/add sequences are avoided on the menus. Such sequences happen inside the synchronization algorithm to establish a certain order of menu items.

Just adding or just removing items seems not to cause any problems.

So a quick solution is to disable reordering for menus. New items will always appear at the menu end initially. This happens when a new macro or package is added. Upon restart of the application, the menu is built from scratch and the proper order is established.

@klayoutmatthias

This comment has been minimized.

Owner

klayoutmatthias commented Jan 2, 2018

@Kazzz-S

I am trying to fix this issue with higher prio because it's my main blocker. Did you observe this problem?

@Kazzz-S

This comment has been minimized.

Contributor

Kazzz-S commented Jan 2, 2018

No, so far.
I can open and close the "assistant" several times without segmentation fault.

Kazzz-S added a commit to Kazzz-S/klayout that referenced this issue Jan 2, 2018

Merge pull request #18 from klayoutmatthias/macos-build
Fixed klayoutmatthias#51: segmentation fault on return to main window
@klayoutmatthias

This comment has been minimized.

Owner

klayoutmatthias commented Jan 4, 2018

Hmmm ... Maybe that's a particular issue with Qt5.9 and/or High Sierra. Nevertheless it should be fixed. Thanks,
Matthias

netbsd-srcmastr pushed a commit to NetBSD/pkgsrc that referenced this issue Jul 24, 2018

Update to 0.25.3
* Use Qt 5 instead of Qt 4

Changelog:
0.25.3          (2018-05-03):

* Enhancement: Compile option to use libcurl instead of QtNetwork
       This workaround enables builds on the native CentOS6
       configuration with the package manager functional.
* Enhancement: Pass label (text) layers through DRC script
       The "labels" method now allows copying labels from a layer
       to the output.
* Enhancement: New "split" method for polygons
       This method will fragment the polygons into two or more
       smaller parts for reducing their vertex count.
* Enhancement: New "dtrans" method for RecursiveShapeIterator
       This method delivers the transformation in micron unit space
* Enhancement: New "insert" methods for Shapes
       Shapes can now insert from another Shapes container and
       from a RecursiveShapeIterator. Possible applications are
       fast flattening and fast region selection.
* Enhancement: New method to generate RDB items from shapes
       RdbItem#add_value from a shape, RdbDatabase#create_items
       from a shapes container or recursive shape iterator and
       RdbDatabase#create_item from a shape.
* Enhancement: DXF and CIF "keep layer names"
       If this option is set in the reader options, layer names
       are not translated into GDS layer/datatype pairs.
       Specifically a layer called "L5" for example is not
       translated to 5/0 and to "L5D0" on output correspondingly.
       The buddy script option is "--keep-layer-names".
* Enhancement: DXF contour joining accuracy
       On the DXF reader's options, a contour joining accuracy
       can be specified. Small gaps smaller than this accuracy
       will be closed when forming joined contours from edges.
       The buddy script option is --dxf-contour-accuracy=value.
* Bugfix: DXF display issue
       In some cases, DXF cell instances did not trigger bounding
       box update and the cells only got visible after save and
       load.
* Bugfix: XOR progress is more realistic
       The progress is updated after the layer has been computed,
       not before.
* Bugfix: klayoutmatthias/klayout#117
       DTrans#itype was broken.
* Bugfix: klayoutmatthias/klayout#116
       Fixed a polygon decomposition bug when writing GDS files
       with big polygons with many holes. As a side effect, the
       polygons with many holes computed by a NOT operation for
       example are less complex and spikes in the cutlines are
       avoided.
* Bugfix: klayoutmatthias/klayout#115
       Reader options were not persisted.
* Bugfix: klayoutmatthias/klayout#114
       Custom line styles not loaded from tech's layer properties
       file.
* Enhancement: klayoutmatthias/klayout#113
       The XOR tool has an option now to heal result shapes which
       cross tile boundaries. The result shape count of tiled
       and non-tiled mode should basically be the same then.
* Bugfix: klayoutmatthias/klayout#112
       Salt package repository relative paths have not been working.
* Bugfix: klayoutmatthias/klayout#109
       Issues with Python 3 and shape properties - property
* Bugfix: klayoutmatthias/klayout#108
       Bugfix on Box#enlarge and Box#moved for empty boxes.
       keys generated with Python 3 could not be written to GDS2.
* Bugfix: klayoutmatthias/klayout#107
       Undo not working with shapes.
* Enhancement: klayoutmatthias/klayout#106
       Search & replace help page enhancements.

0.25.2          (2018-03-20):
* Bugfix: klayoutmatthias/klayout#90
      DRC: "extended" was not working as expected with "joined = true"
* Bugfix: klayoutmatthias/klayout#89
      Display issue on MacOS fixed
* Enhancement: klayoutmatthias/klayout#85
      IDE debugger: files can be excluded from showing exceptions when
      they are thrown. To exclude a file press the new "Ignore" button
      when the debugger tells you an exception has been generated.
      To re-able exception reporting, clear the list of the files
      in the IDE settings ("Debugging" tab)
      The macro IDE settings can now be edited in the File/Setup
      dialog.
* Bugfix: klayoutmatthias/klayout#94
      Retina displays are support to some extend on MacOS.
      An open topic is the quality of the icons.
* Enhancement: build system for MacOS

0.25.1          (2018-02-23):
* Enhancements: build compatibility with MacOS and Qt 5.9.
      Qt 4.6 supported now as well with one restriction:
      the package installation feature is not working.
* Bugfixs: Package manager
       - Remove button wasn't enabled if multiple packages were selected
       - A potential crash ob removing packages was fixed
* Enhancement: 64 bit coordinate support enabled on Windows builds
* Further bugfixes: See links
       - klayoutmatthias/klayout#21 (Autorun(-early) doesn't seem to run when lym files are inside a package)
       - klayoutmatthias/klayout#24 (Text insert dialog bug - Ok button isn't working)
       - klayoutmatthias/klayout#26 (Exceptions are reported every time they propagate up in the call chain in the ruby debugger)
       - klayoutmatthias/klayout#28 (CIF format detection failed)
       - klayoutmatthias/klayout#30 (Writer options dialog non-functional on a fresh configuration)
       - klayoutmatthias/klayout#32 (Rounding issue with instance properties)
       - klayoutmatthias/klayout#33 (Plugin factory not working when using with Python)
       - klayoutmatthias/klayout#36 (Hardening against destruction of object inside event handler)
       - klayoutmatthias/klayout#39 (Action cannot be reassigned)
       - klayoutmatthias/klayout#40 (Crash in Python binding)
       - klayoutmatthias/klayout#41 (Polygon#touches? issue)
       - klayoutmatthias/klayout#42 (Headless mode support with Qt5/-zz)
       - klayoutmatthias/klayout#43 (Crash when using Qt specific command line options)
       - klayoutmatthias/klayout#44 (Transformation constructor with x,y not working)
       - klayoutmatthias/klayout#45 (Partial selection does not capture instance)
       - klayoutmatthias/klayout#48 (Cancel does not reset current tool)
       - klayoutmatthias/klayout#51 (Segmentation fault on return to main window and other opportunities)
       - klayoutmatthias/klayout#53 (Unreadable 'about' text)
       - klayoutmatthias/klayout#62 (QXmlSimpleReader#parse cannot be called)
       - klayoutmatthias/klayout#63 (Wrong output on DRC non_interacting with empty second input)
       - klayoutmatthias/klayout#64 (Crash on exit)
       - klayoutmatthias/klayout#68 (OASIS reader issue with degenerated shapes)
       - klayoutmatthias/klayout#69 (DRC: 'inside' does not merge shapes of second input)
       - klayoutmatthias/klayout#71 (Target cell argument is required)
       - klayoutmatthias/klayout#72 (Edges/Region NOT issue)
       - klayoutmatthias/klayout#73 (Allow 'change layers' on PCells which support a single layer parameter)
       - klayoutmatthias/klayout#74 (Small-corner boolean issue)
       - klayoutmatthias/klayout#75 (Python PCell issue when parameters are called 'layer')
       - klayoutmatthias/klayout#79 (Replace function enabled also for read-only macros)
* Further enhancements: see links
       - klayoutmatthias/klayout#29 (Permissive mode for OASIS writer on odd-width paths)
       - klayoutmatthias/klayout#59 (Async download of package index and details)
       - klayoutmatthias/klayout#66 (Authentication dialog indicates retry)
       - klayoutmatthias/klayout#77 (Layout#copy_tree now works in non-editable mode too)

0.25            (2017-11-04):
* Enhancement: Menu customization
      Menu items can be disabled or enabled now. The former
      "Key Bindings" configuration page has been turned into
      "Menu Customization". Check boxes allow enabling or
      disabling of menu items. Disabled menu items are not
      shown.
      A search filter allows quick selection of menu items
      by title or path.
* Enhancement: The cell tree no longer is collapsed on edits
      or when the sorting order changes.
* Enhancement: Using a special menu path, macros can be
      configured to appear in submenus now.
* Enhancement: KLAYOUT_HOME environment variable to
      control the location of the application folder.
      The application folder is the place where KLayout
      keeps the configuration, macros, packages and
      other things.
* Enhancements: Major overhaul of the build environment
      - Qt5 supported now
      - Employs qmake as build system
      - Reorganisation of the sources
      - Continuous integration enabled (unit tests
        integrated in .pro files, JUnit output etc.)
      - Compatible with the clang compiler
* Enhancements: Buddy tools: KLayout now comes with a set of
      additional executables that provide some functionality
      subset in a lean way. These binaries are named "strm..."
      and are installed along with KLayout.
      - strm2cif: converts any format to CIF
      - strm2dxf: converts any format to DXF
      - strm2gds: converts any format to GDS2
      - strm2gdstxt: converts any format to GDS2/text
      - strm2oas: converts any format to OASIS
      - strm2txt: converts any format to plain text (internally)
      - strmclip: creates a clip from a file
      - strmcmp: compares two files (logically)
      - strmxor: compares two files (geometrically)
      For more information, use the "-h" or "--help" option.
* Enhancements: HTTPS support for loading files from URL's directly
* Enhancements: Numerous enhancements and optimizations in the RBA/pya
      area and in the debugger.
* Enhancements: KLayout notifies the user when a file was changed and
      asks whether to reload.
* Enhancements: "File cell or layer": type into the cell or layer list to jump to the
      cell name typed.
* Enhancements: Advanced search features in the filter entry box
      for the cell selection form: Case sensitive/insensitive,
      glob pattern, clear button.
* Enhancements: Tree expansion icons have a better contrast now on Windows
      with dark background.
* Enhancements: Forward and backward navigation buttons in the main window.
      These buttons jump to the previous or next display state:
      zoom window, hierarchy depth, etc..
* Enhancements: A Package manager is provided. Packages are add-ons for
      KLayout and can include macros, script libraries, fonts
      for the TEXT PCell, technologies, DRC scripts etc.
      Packages can be published on GitHub or any server
      supporting WebDAV. After registering a package, users
      can install or update packages with a few clicks.
      For more information see https://github.com/klayoutmatthias/klayout/wiki
      or "About Packages" in the "Various Topics" area of the main
      documentation. The package manager is found in the "Tools"
      menu under "Manage Packages".
* Enhancements: LEF/DEF reader:
       - Compatibility fixes with version 5.8
       - Regions and Groups are supported now
       - LEF/DEF is a standare format now and
         can be used with "File/Open" for example.
* Enhancement: DXR reader supports variable path widths now
* Enhancement: XOR provides graphical progress
* Enhancements: Libraries can be associated with a technology. Only libraries
      associated with the selected technology are shown in the selection
      dialog.
* Enhancements: Overlapping instances are easier to select now (instance
      selection cycling).
* Enhancements: Many more methods in RBA/pya. For example:
       - Ability to directly insert "D" types (such as DBox
         into layouts and cells.
       - RBA::RecursiveShapeIterator now supports complex (non-rectangular)
         search regions
       - A more consistent type framework (consistent complex transformation
         types, vectors)
       - More intuitive interface in certain objects (i.e. CellView,
         LayerPropertiesNode, Annotation etc.). Changing an attribute
         usually has an immediate effect on the respective property now
         ("live objects")
       - Hash functions for certain objects - Box, Edge, Trans, Polygon,
         and other objects can be used as dictionary keys now.
       - New import methods for Region, EdgePairs and Edges
       - New features for LayerMapping and CellMapping
       - Multiple selected cells in LayoutView
       - RBA::TextGenerator to supply the Basic.TEXT PCell's
         functionality as static feature
       - Receivers can be added to signals and removed from
         signals now.
       - Individual instance iterator for CellInstArray
       - ...
* Enhancements: Enhanced layout statistics form with detailed shape
      statistics.
* Enhancements: Line styles (dashed, dotted etc.) available now.
      Works best with manhattan layouts.
* Enhancements: "Marked box mode": boxes are drawn with a cross.
* Enhancements: Arbitrary pattern size for custom fill pattern (no
      limited to multiples of 8). Max size is 32x32.
      Enhanced annotations:
       - Ellipses
       - Position markers
       - Text alignment
       - "Auto measure" rulers (place a ruler measuring the
         distances between adjacent objects with a single
         click)
* Enhancements: DRC enhancements:
       - Text support
       - "smoothed" function
       - "layers" function delivers all layers read
       - Polygon with edge interactions
       - middle and extent_refs methods for center point and other
         references
       - "corners" function
       - "collect...", "select" and "each" methods
* Enhancements: GDS2 paths can now use the MultiXY extension too.
* Enhancements: X2 Support for Gerber import.
* Enhancements: A function to reset the window state after the
      window has been misconfigured (i.e. detaching or closing
      the dockable windows). This feature is found in
      View/Restore Window.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment