Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

contract implementation for KIP-103 interface #1810

Merged
merged 4 commits into from Mar 17, 2023
Merged

Conversation

0xxlegolas
Copy link
Contributor

Proposed changes

Implementation of KIP-103 interface

  • refactored smart contract implementation according to kip103 interface
  • added snapshot function to get current values of state variables

References

KGP6
klaytn/kips#104

Types of changes

Please put an x in the boxes related to your change.

  • Bugfix
  • New feature or enhancement
  • Others

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING GUIDELINES doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes ($ make test)
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Related issues

  • Please leave the issue numbers or links related to this PR here.

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@0xxlegolas 0xxlegolas added the draft More implementation is needed label Mar 16, 2023
@blukat29 blukat29 mentioned this pull request Mar 17, 2023
9 tasks
@0xxlegolas 0xxlegolas self-assigned this Mar 17, 2023
@ian0371
Copy link
Contributor

ian0371 commented Mar 17, 2023

@aidan-kwon Don't forget to rerun "go generate" from #1809 after this PR is merged.

@blukat29 blukat29 removed the draft More implementation is needed label Mar 17, 2023
@0xxlegolas 0xxlegolas merged commit 9fb6127 into klaytn:dev Mar 17, 2023
11 checks passed
@blukat29 blukat29 mentioned this pull request Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants