Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
reducers for outputting raw binary files, tokyo cabinet dbs or constant dbs #32
Had a quick look at the code and it looks great to me. Definitely some very nice contributions, thanks!
The "dumbo.contrib" package seems a fair enough place to put these reducers, but I wouldn't mind converting "dumbo.lib" in a package either as long as we put everything it already contains now (either directly or indirectly via imports) in "dumbo/lib/init.py" to preserve backwards compatibility. I might even prefer the latter, unless I'm overlooking some potential downsides?
I do have one comment after a quick glance through your code though: The tests you added should probably go in "tests/" instead of "dumbo/contrib".