Skip to content
This repository

reducers for outputting raw binary files, tokyo cabinet dbs or constant dbs #32

Closed
klbostee opened this Issue March 17, 2011 · 3 comments

2 participants

Klaas Bosteels Daniel Graña
Klaas Bosteels
Owner

See recent commits on https://github.com/dangra/dumbo

Klaas Bosteels
Owner

Had a quick look at the code and it looks great to me. Definitely some very nice contributions, thanks!

The "dumbo.contrib" package seems a fair enough place to put these reducers, but I wouldn't mind converting "dumbo.lib" in a package either as long as we put everything it already contains now (either directly or indirectly via imports) in "dumbo/lib/init.py" to preserve backwards compatibility. I might even prefer the latter, unless I'm overlooking some potential downsides?

I do have one comment after a quick glance through your code though: The tests you added should probably go in "tests/" instead of "dumbo/contrib".

Daniel Graña dangra referenced this issue from a commit in dangra/dumbo April 21, 2011
Daniel Graña GH-32: convert dumbo.lib module to a package 1ff5fef
Daniel Graña dangra referenced this issue from a commit April 21, 2011
Commit has since been removed from the repository and is no longer available.
Daniel Graña

My time to apology for delayed answer, finally got some free time to work on this, check recent commits tagged by GH-32 in my fork. thanks!

Daniel Graña dangra referenced this issue from a commit in dangra/dumbo February 21, 2011
Daniel Graña GH-32: Add generic reducer to output raw files
- It is named RawReducer
- Handles outputing to single or multiples files (requires feathers)
- Include working examples to generate tokyo-cabinets, constant dbs, and jsonlines
- Last but not least, unittests!
4feb7d7
Klaas Bosteels
Owner

Merged in 0094bdb. Thanks Daniel!

Klaas Bosteels klbostee closed this April 27, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.