Fix #62 Added path as key[0] for MultiMapper #63

Closed
wants to merge 1 commit into
from

Projects

None yet

2 participants

@mshevelev

Please check the fix. Please note that there is small incompatibility with previous versions, i.e. if somebody uses keys in multimappers, however this is very rare. Now a developer will have access to filepaths and should implicitly ignore them if he os she wants...

Mikhail Shevelev Fix #62 Added path as key[0] for MultiMapper
Note: for all mapper added into MultiMapper input key is a tuple
with key[0] equal to pathname. This works regardless of "addpath" option.
f884844
@klbostee
Owner

Using the keys in multimappers is not that rare actually. Not keen on introducing this backwards-incompatibility to be honest. There must be a better way of fixing this...

@klbostee
Owner
klbostee commented Sep 5, 2013

So going to close this pull requests as it's probably a bad idea to introduce this backwards incompatibility. I'm open to alternative solutions though.

@klbostee klbostee closed this Sep 5, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment