Catch too many or too few outputs with mapredtest. #73

Merged
merged 1 commit into from Sep 4, 2013

Conversation

Projects
None yet
2 participants
@jkleint
Contributor

jkleint commented May 8, 2013

mapredtest was only iterating over the actual output, silently ignoring any
further expected output. In the extreme case, a mapper or reducer that output
nothing would always pass. The error when a map/reduce did not produce enough
output was also not helpful. This patch factors iterator comparison into a
function to reduce duplicated code, and adds and corrects tests.

John Kleint
Catch too many or too few outputs with mapredtest.
mapredtest was only iterating over the actual output, silently ignoring any
further expected output.  In the extreme case, a mapper or reducer that output
nothing would always pass.  The error when a map/reduce did not produce enough
output was also not helpful.  This patch factors iterator comparison into a
function to reduce duplicated code, and adds and corrects tests.

klbostee added a commit that referenced this pull request Sep 4, 2013

Merge pull request #73 from jkleint/mapredtest
Catch too many or too few outputs with mapredtest.

@klbostee klbostee merged commit d1440f2 into klbostee:master Sep 4, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment