Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LLVM 6.0 #894

Merged
merged 3 commits into from
Oct 26, 2018
Merged

LLVM 6.0 #894

merged 3 commits into from
Oct 26, 2018

Conversation

jirislaby
Copy link
Contributor

just checking how this stands, this is not to be merged yet.

@ccadar ccadar changed the title Llvm 60 [WIP] LLVM 6.0 May 21, 2018
@codecov
Copy link

codecov bot commented May 24, 2018

Codecov Report

Merging #894 into master will decrease coverage by <.01%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master     #894      +/-   ##
==========================================
- Coverage   66.05%   66.04%   -0.01%     
==========================================
  Files         150      150              
  Lines       17094    17095       +1     
  Branches     3956     3956              
==========================================
  Hits        11291    11291              
- Misses       4015     4016       +1     
  Partials     1788     1788
Impacted Files Coverage Δ
lib/Module/RaiseAsm.cpp 70.45% <ø> (ø) ⬆️
lib/Support/PrintVersion.cpp 0% <0%> (ø) ⬆️

@jirislaby jirislaby force-pushed the llvm_60 branch 8 times, most recently from 601e181 to b94a564 Compare May 27, 2018 08:27
@jirislaby jirislaby force-pushed the llvm_60 branch 8 times, most recently from 87bf920 to 34ba4a7 Compare June 15, 2018 08:52
@jirislaby
Copy link
Contributor Author

The Travis CI build passed

Heh 👍

@MartinNowack
Copy link
Contributor

@jirislaby Nice, excellent news.

@MartinNowack
Copy link
Contributor

@jirislaby I would like to get the WIP removed from this one.
Can you rebase it and remove the commit 3c2ab0c.

In addition, set the default to https://github.com/klee/klee/blob/master/CMakeLists.txt#L523
'Debug+Asserts'.

And add to 0b967e2 the modification of

LLVMCC.Flags += -O0
to support -disable-O0-optnone as well.

@jirislaby jirislaby force-pushed the llvm_60 branch 2 times, most recently from d7987c3 to 72b667c Compare July 19, 2018 07:24
@jirislaby jirislaby force-pushed the llvm_60 branch 3 times, most recently from 167edbc to c5d249a Compare July 20, 2018 12:14
@jirislaby
Copy link
Contributor Author

jirislaby commented Jul 21, 2018

We are green again 👍. And now even with assertions on (which caught one more bug/change in LLVM
9dc8a89).

@jirislaby jirislaby force-pushed the llvm_60 branch 2 times, most recently from b6af5c0 to 8cbae15 Compare September 2, 2018 12:04
@MartinNowack MartinNowack changed the title [WIP] LLVM 6.0 LLVM 6.0 Oct 26, 2018
@MartinNowack
Copy link
Contributor

@jirislaby Can you rebase? Modifications are really minor and look fine. This is ready to go in as well.

I.e. klee::printVersion should now have a parameter -- the output
stream. Change both the prototype and the implementation to handle this
properly.

Signed-off-by: Jiri Slaby <jirislaby@gmail.com>
Some headers were moved from llvm/Target/ to llvm/CodeGen/. Handle that.

Signed-off-by: Jiri Slaby <jirislaby@gmail.com>
Signed-off-by: Jiri Slaby <jirislaby@gmail.com>
Copy link
Contributor

@MartinNowack MartinNowack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!! Thanks a lot for your effort!

@MartinNowack MartinNowack merged commit 0525bd7 into klee:master Oct 26, 2018
@jirislaby jirislaby deleted the llvm_60 branch October 26, 2018 15:32
@arrowd
Copy link
Contributor

arrowd commented Oct 26, 2018

Wohoo. Now the LLVM 6.0 support is merged, can we hope for a new KLEE release?

@ccadar
Copy link
Contributor

ccadar commented Oct 26, 2018

@arrowd Yes, we're working toward a new release with lots of significant changes. I hope to make it available sometime in November.

@arrowd
Copy link
Contributor

arrowd commented Feb 23, 2019

Any ETA on the release? I'm asking, because I'm maintaining a FreeBSD port of KLEE and LLVM 3.8 is going to be removed from ports soon, breaking KLEE port too.

@ccadar
Copy link
Contributor

ccadar commented Feb 25, 2019

@arrowd , I can't believe I was hoping for a November release and it is now February :(

I've just talked to @MartinNowack and we agreed to make a release by 18 March. And I plan to commit to this, even if some items on our wish list won't make it. I hope this is fine with respect to the FreeBSD port.

The good news is that we've been testing KLEE with LLVM 6.0 in several projects, and everything seems to be working as expected.

@arrowd
Copy link
Contributor

arrowd commented Feb 25, 2019

@ccadar We surely can wait for another month. Even if the port would be removed, I'll just restore it again once KLEE get released.

BTW, I just got an idea: how about making a beta release or a release candidate of some sort? I'll be able to wrap it into a port and this way you will get even more testing coverage.

The only request is to name it 2.0.0-<something>, this way 2.0.0 version would be higher and the versioning wouldn't go backwards.

@ccadar
Copy link
Contributor

ccadar commented Mar 4, 2019

Hi @arrowd , many thanks for the offer. This sounds like a good idea, although I'm not sure how much in advance we'll have the final version. As an approximation, the current version is quite close to what we'll release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants