-
Notifications
You must be signed in to change notification settings - Fork 661
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LLVM 6.0 #894
LLVM 6.0 #894
Conversation
Codecov Report
@@ Coverage Diff @@
## master #894 +/- ##
==========================================
- Coverage 66.05% 66.04% -0.01%
==========================================
Files 150 150
Lines 17094 17095 +1
Branches 3956 3956
==========================================
Hits 11291 11291
- Misses 4015 4016 +1
Partials 1788 1788
|
601e181
to
b94a564
Compare
87bf920
to
34ba4a7
Compare
Heh 👍 |
|
@jirislaby Nice, excellent news. |
e13002e
to
3c2ab0c
Compare
|
@jirislaby I would like to get the WIP removed from this one. In addition, set the default to https://github.com/klee/klee/blob/master/CMakeLists.txt#L523 And add to 0b967e2 the modification of klee/runtime/Makefile.cmake.bitcode.rules Line 43 in 79ac709
-disable-O0-optnone as well.
|
d7987c3
to
72b667c
Compare
167edbc
to
c5d249a
Compare
|
We are green again 👍. And now even with assertions on (which caught one more bug/change in LLVM |
b6af5c0
to
8cbae15
Compare
0e4e146
to
d933bb2
Compare
|
@jirislaby Can you rebase? Modifications are really minor and look fine. This is ready to go in as well. |
I.e. klee::printVersion should now have a parameter -- the output stream. Change both the prototype and the implementation to handle this properly. Signed-off-by: Jiri Slaby <jirislaby@gmail.com>
Some headers were moved from llvm/Target/ to llvm/CodeGen/. Handle that. Signed-off-by: Jiri Slaby <jirislaby@gmail.com>
Signed-off-by: Jiri Slaby <jirislaby@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great!! Thanks a lot for your effort!
|
Wohoo. Now the LLVM 6.0 support is merged, can we hope for a new KLEE release? |
|
@arrowd Yes, we're working toward a new release with lots of significant changes. I hope to make it available sometime in November. |
|
Any ETA on the release? I'm asking, because I'm maintaining a FreeBSD port of KLEE and LLVM 3.8 is going to be removed from ports soon, breaking KLEE port too. |
|
@arrowd , I can't believe I was hoping for a November release and it is now February :( I've just talked to @MartinNowack and we agreed to make a release by 18 March. And I plan to commit to this, even if some items on our wish list won't make it. I hope this is fine with respect to the FreeBSD port. The good news is that we've been testing KLEE with LLVM 6.0 in several projects, and everything seems to be working as expected. |
|
@ccadar We surely can wait for another month. Even if the port would be removed, I'll just restore it again once KLEE get released. BTW, I just got an idea: how about making a beta release or a release candidate of some sort? I'll be able to wrap it into a port and this way you will get even more testing coverage. The only request is to name it |
|
Hi @arrowd , many thanks for the offer. This sounds like a good idea, although I'm not sure how much in advance we'll have the final version. As an approximation, the current version is quite close to what we'll release. |
just checking how this stands, this is not to be merged yet.