Skip to content

Add AVIF support #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Dec 21, 2022
Merged

Add AVIF support #36

merged 17 commits into from
Dec 21, 2022

Conversation

RReverser
Copy link
Contributor

Note this currently doesn't port upstream tests; not sure if I'll get around to that, but figured I'll submit PR anyway.

libheif needs those, and disabling them just for libheif leads to linking issues. I could probably disable them in linker too only if AVIF is enabled, but not sure it's worth the complexity.
This has issues with -frtti which is now enabled for libheif.
@kleisauke kleisauke added this to the v0.0.5 milestone Dec 14, 2022
@RReverser RReverser marked this pull request as draft December 14, 2022 19:06
@RReverser
Copy link
Contributor Author

Converted to draft because, aside from tests, this clearly needs more work to be supported as a dynamic module.

@kleisauke
Copy link
Owner

Great! I was able to support this as a dynamic module and also added some test coverage for this (by porting libvips' AVIF tests).
RReverser/wasm-vips@avif...kleisauke:wasm-vips:avif-RReverser

@RReverser
Copy link
Contributor Author

Great! I was able to support this as a dynamic module and also added some test coverage for this (by porting libvips' AVIF tests).

Feel free to push directly to my PR, might be easier than tracking across different branches.

@RReverser
Copy link
Contributor Author

Or, alternatively, I can close mine and you open yours. Whichever is easier.

@kleisauke
Copy link
Owner

Feel free to push directly to my PR, might be easier than tracking across different branches.

I just pushed it to the branch associated with this PR.

@RReverser RReverser marked this pull request as ready for review December 21, 2022 13:55
Copy link
Owner

@kleisauke kleisauke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! This will be in v0.0.5.

@kleisauke kleisauke merged commit 085b59d into kleisauke:master Dec 21, 2022
kleisauke added a commit that referenced this pull request Dec 21, 2022
@RReverser RReverser deleted the avif branch December 22, 2022 02:46
@atjn atjn mentioned this pull request Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants