-
-
Notifications
You must be signed in to change notification settings - Fork 30
Add AVIF support #36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add AVIF support #36
Conversation
libheif needs those, and disabling them just for libheif leads to linking issues. I could probably disable them in linker too only if AVIF is enabled, but not sure it's worth the complexity.
This has issues with -frtti which is now enabled for libheif.
Converted to draft because, aside from tests, this clearly needs more work to be supported as a dynamic module. |
Depends on commit: strukturag/libheif@024d32c
Resolves a `BindingError` during dynamic lib load. ``` BindingError: Cannot register public name 'heif_error_code' twice ``` See commit: kleisauke/libheif@34dda27
The testsuite passes without increasing the stack size.
Great! I was able to support this as a dynamic module and also added some test coverage for this (by porting libvips' AVIF tests). |
Feel free to push directly to my PR, might be easier than tracking across different branches. |
Or, alternatively, I can close mine and you open yours. Whichever is easier. |
I just pushed it to the branch associated with this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! This will be in v0.0.5.
Note this currently doesn't port upstream tests; not sure if I'll get around to that, but figured I'll submit PR anyway.